Skip to content

fix(gesture): restore double-tap recognition - #1095

Merged
Kyle-Ye merged 6 commits into
mainfrom
bugfix/double_tap
Sep 25, 2026
Merged

Kyle-Ye merged 6 commits into
mainfrom
bugfix/double_tap

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Keep exclusive gestures pending while waiting for a second tap when the first child has failed.
  • Preserve the gesture event clock when merging view inputs so repeat deadlines use the correct time source.
  • Treat ended phases as active for duration initialization and exclusive gesture state propagation.
  • Cover single and double taps with the shared iOS and macOS UX tests.
  • Use Hammer 0.19.2 so background mouse gestures reach recognizers on macOS 15.

Dependency

@Kyle-Ye

Kyle-Ye commented Sep 24, 2026

Copy link
Copy Markdown
Member Author

/uxtest all

@github-actions github-actions Bot added area: event-gesture Events, gestures, tracing, or interaction plumbing. type: bug Something is not working correctly. labels Sep 24, 2026
@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 33.12%. Comparing base (ffb7d7d) to head (ef8ee67).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...enSwiftUICore/Event/Gesture/ExclusiveGesture.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
- Coverage   33.59%   33.12%   -0.47%     
==========================================
  Files         797      803       +6     
  Lines       61895    63669    +1774     
==========================================
+ Hits        20792    21089     +297     
- Misses      41103    42580    +1477     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tuist

tuist Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Ran test modules Commit
OpenSwiftUI ✅ 7 e423a5f04

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 1m 12s e423a5f04

@github-actions github-actions Bot added the area: tests Test suites, UI tests, fixtures, snapshots, and test support code. label Sep 25, 2026
@Kyle-Ye

Kyle-Ye commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

/uxtest all

@Kyle-Ye
Kyle-Ye merged commit 544f617 into main Sep 25, 2026
6 checks passed
@Kyle-Ye
Kyle-Ye deleted the bugfix/double_tap branch September 25, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: event-gesture Events, gestures, tracing, or interaction plumbing. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant