Skip to content

fix(observation): restore body updates for observable state - #1104

Merged
Kyle-Ye merged 4 commits into
mainfrom
bugfix/observation
Sep 27, 2026
Merged

Kyle-Ye merged 4 commits into
mainfrom
bugfix/observation

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Sep 26, 2026

Copy link
Copy Markdown
Member

Summary

  • Restore body updates when a view reads an observable model stored in State: use subgraphOrNil and update the graph dependency revisions.
  • Use dynamic support frameworks in Example so the app and OpenSwiftUICore share observation tracking state. Keep OpenObservationCxx static to match the distribution configuration.
  • Add a counter example and a UX regression that checks the sequence 0, 1, 2 after consecutive taps with SwiftUI and OpenSwiftUI.

Validation

  • Example project generation and whitespace checks passed.
  • Builds and UX tests were not run.

Dependency

@github-actions github-actions Bot added area: data-flow State, binding, environment, preference, observation, or property data flow. area: example Example apps, previews, sample projects, screenshots, or demo assets. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: bug Something is not working correctly. labels Sep 26, 2026
@tuist

tuist Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Ran test modules Commit
OpenSwiftUI ✅ 7 88fafed37

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 40.6s 88fafed37

@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.26%. Comparing base (02e5baf) to head (553044f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1104      +/-   ##
==========================================
+ Coverage   28.87%   33.26%   +4.38%     
==========================================
  Files         752      805      +53     
  Lines       55545    63992    +8447     
==========================================
+ Hits        16039    21284    +5245     
- Misses      39506    42708    +3202     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit b90679e into main Sep 27, 2026
6 checks passed
@Kyle-Ye
Kyle-Ye deleted the bugfix/observation branch September 27, 2026 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: data-flow State, binding, environment, preference, observation, or property data flow. area: example Example apps, previews, sample projects, screenshots, or demo assets. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant