Skip to content

feat(render): add view blend modes - #1127

Merged
Kyle-Ye merged 3 commits into
feature/effect-compositing-groupfrom
feature/effect
Oct 7, 2026
Merged

Kyle-Ye merged 3 commits into
feature/effect-compositing-groupfrom
feature/effect

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Oct 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Add view modifiers and renderer effects for public, extended, and graphics blend modes.
  • Apply QuartzCore compositing filters and support conversion between filter names and RenderBox blend modes.
  • Add a shared example, snapshot coverage for all 21 public modes, and shim tests for mappings and fallback values.
  • Update the DPF and ORB revisions to the merged blend mode declarations.

All 21 snapshot cases passed against SwiftUI references on iOS 18.5. Both native ORB and Apple header paths passed 108 focused shim cases.

Stack

Depends on #1126.

Dependency

@Kyle-Ye
Kyle-Ye added this pull request to stack #1128 October 7, 2026 12:10
@github-actions github-actions Bot added area: example Example apps, previews, sample projects, screenshots, or demo assets. area: graphics Color, shape, gradient, image, symbols, and graphics primitives. area: rendering DisplayList, render backends, renderer hosts, drawing, and effects. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: feature New API, behavior, platform support, or user-facing capability. labels Oct 7, 2026
@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.41%. Comparing base (631bf3b) to head (0d11757).

Files with missing lines Patch % Lines
...UICore/Render/RendererEffect/BlendModeEffect.swift 0.00% 16 Missing ⚠️
...urces/OpenSwiftUICore/Graphic/GraphicsFilter.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           feature/effect-compositing-group    #1127      +/-   ##
====================================================================
- Coverage                             30.79%   26.41%   -4.39%     
====================================================================
  Files                                   877      818      -59     
  Lines                                 70864    61556    -9308     
====================================================================
- Hits                                  21825    16259    -5566     
+ Misses                                49039    45297    -3742     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tuist

tuist Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Ran test modules Commit
OpenSwiftUI ✅ 7 db66e46cc

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 58.5s db66e46cc

@Kyle-Ye

Kyle-Ye commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

/uitest all osui-iag update only-testing=OpenSwiftUIUITests/BlendModeEffectUITests

@Kyle-Ye
Kyle-Ye merged commit e443e3c into main Oct 7, 2026
7 of 9 checks passed
@Kyle-Ye
Kyle-Ye deleted the feature/effect branch October 7, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: example Example apps, previews, sample projects, screenshots, or demo assets. area: graphics Color, shape, gradient, image, symbols, and graphics primitives. area: rendering DisplayList, render backends, renderer hosts, drawing, and effects. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: feature New API, behavior, platform support, or user-facing capability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant