Skip to content

feat(gesture): implement physical button press gesture - #1134

Merged
Kyle-Ye merged 1 commit into
mainfrom
feature/physical_button
Oct 9, 2026
Merged

Kyle-Ye merged 1 commit into
mainfrom
feature/physical_button

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Oct 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Add PhysicalButtonPressGesture for iOS and visionOS, with allowed-button filtering and inherited gesture dependency handling.
  • Add AllowedButtonTypes for all ten physical button types, including membership and mutation operations.

Validation

  • Scoped behavior checks cover button masks, phase transitions, and gesture dependencies.
  • Syntax checks pass for iOS, visionOS, and macOS.

@github-actions github-actions Bot added area: event-gesture Events, gestures, tracing, or interaction plumbing. platform: iOS iOS-specific behavior or support. platform: visionOS visionOS-specific behavior or support. type: feature New API, behavior, platform support, or user-facing capability. labels Oct 9, 2026

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deep Code Review Agent🐛

Review completed with 2 suggestions.

Reviewed commit: 4538129

Comment thread Sources/OpenSwiftUI/Event/Gesture/PhysicalButtonPressGesture.swift
Comment thread Sources/OpenSwiftUI/Event/Gesture/PhysicalButtonPressGesture.swift
@Kyle-Ye
Kyle-Ye force-pushed the feature/physical_button branch from 4538129 to ccb7fca Compare October 9, 2026 16:27
@Kyle-Ye
Kyle-Ye merged commit aefa4e6 into main Oct 9, 2026
4 of 5 checks passed
@Kyle-Ye
Kyle-Ye deleted the feature/physical_button branch October 9, 2026 16:29
@tuist

tuist Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Ran test modules Commit
OpenSwiftUI ✅ 7 fa0459057

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 41.7s fa0459057

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.59%. Comparing base (4fa6573) to head (ccb7fca).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1134      +/-   ##
==========================================
- Coverage   30.89%   26.59%   -4.30%     
==========================================
  Files         880      821      -59     
  Lines       71040    61716    -9324     
==========================================
- Hits        21945    16411    -5534     
+ Misses      49095    45305    -3790     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: event-gesture Events, gestures, tracing, or interaction plumbing. platform: iOS iOS-specific behavior or support. platform: visionOS visionOS-specific behavior or support. type: feature New API, behavior, platform support, or user-facing capability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant