WIP Windows lite by Osyotr · Pull Request #2 · Osyotr/organicmaps

Osyotr · 2025-07-28T21:16:32Z

No description provided.

Osyotr · 2026-03-04T10:19:53Z

 };

-#if defined(OMIM_OS_WINDOWS)  //&& defined(PROFILER_COMMON)
+#if 0 && defined(OMIM_OS_WINDOWS)  //&& defined(PROFILER_COMMON)


TODO https://learn.microsoft.com/en-us/windows/win32/sbscs/application-manifests#consoleallocationpolicy

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

Android Lint

⚠️ [Android Lint] _{reported by reviewdog 🐶}
ContentDescription: Missing contentDescription attribute on image

organicmaps/android/app/src/main/res/layout/altitude_chart_panel.xml

Line 128 in 668cef2

<ImageView

⚠️ [Android Lint] _{reported by reviewdog 🐶}
UseKtx: Use the KTX extension function Canvas.withTranslation instead?

organicmaps/android/app/src/main/java/app/organicmaps/widget/RoutingToolbarButton.kt

Line 32 in 668cef2

canvas.save()

⚠️ [Android Lint] _{reported by reviewdog 🐶}
UseKtx: Use the KTX extension function Int.toDrawable instead?

organicmaps/android/app/src/main/java/app/organicmaps/routing/SectionDividerItemDecoration.kt

Line 14 in 668cef2

    
           ColorDrawable(ThemeUtils.getColor(context, androidx.appcompat.R.attr.dividerHorizontal))

⚠️ [Android Lint] _{reported by reviewdog 🐶}
ClickableViewAccessibility: Custom view ColorGridView overrides onTouchEvent but not performClick

organicmaps/android/app/src/main/java/app/organicmaps/widget/colorpicker/ColorGridView.kt

Line 122 in 668cef2

    
           override fun onTouchEvent(event: MotionEvent): Boolean = when (event.actionMasked) {

⚠️ [Android Lint] _{reported by reviewdog 🐶}
ClickableViewAccessibility: Custom view RoundSlider overrides onTouchEvent but not performClick

organicmaps/android/app/src/main/java/app/organicmaps/widget/colorpicker/RoundSlider.kt

Line 100 in 668cef2

    
           override fun onTouchEvent(event: MotionEvent): Boolean = when (event.actionMasked) {

⚠️ [Android Lint] _{reported by reviewdog 🐶}
ClickableViewAccessibility: Custom view SpectrumColorView overrides onTouchEvent but not performClick

organicmaps/android/app/src/main/java/app/organicmaps/widget/colorpicker/SpectrumColorView.kt

Line 167 in 668cef2

    
           override fun onTouchEvent(event: MotionEvent): Boolean = when (event.actionMasked) {

⚠️ [Android Lint] _{reported by reviewdog 🐶}
ContentDescription: Missing contentDescription attribute on image

organicmaps/android/app/src/main/res/layout/place_page_route_ref.xml

Line 38 in 668cef2

<ImageView

⚠️ [Android Lint] _{reported by reviewdog 🐶}
RtlSymmetry: When you define paddingEnd you should probably also define paddingStart for right-to-left symmetry

organicmaps/android/app/src/main/res/layout/place_page_route_ref.xml

Line 17 in 668cef2

android:paddingEnd="@dimen/margin_half"

⚠️ [Android Lint] _{reported by reviewdog 🐶}
SetTextI18n: Number formatting does not take into account locale settings. Consider using String.format instead.

organicmaps/android/app/src/main/java/app/organicmaps/widget/colorpicker/ColorSlidersView.kt

Line 131 in 668cef2

redValue.text = red.toString()

⚠️ [Android Lint] _{reported by reviewdog 🐶}
SetTextI18n: Number formatting does not take into account locale settings. Consider using String.format instead.

organicmaps/android/app/src/main/java/app/organicmaps/widget/colorpicker/ColorSlidersView.kt

Line 132 in 668cef2

greenValue.text = green.toString()

⚠️ [Android Lint] _{reported by reviewdog 🐶}
SetTextI18n: Number formatting does not take into account locale settings. Consider using String.format instead.

organicmaps/android/app/src/main/java/app/organicmaps/widget/colorpicker/ColorSlidersView.kt

Line 133 in 668cef2

blueValue.text = blue.toString()

⚠️ [Android Lint] _{reported by reviewdog 🐶}
SetTextI18n: String literal in setText can not be translated. Use Android resources instead.

organicmaps/android/app/src/main/java/app/organicmaps/widget/colorpicker/ColorSlidersView.kt

Line 135 in 668cef2

hexInput.setText("%02X%02X%02X".format(red, green, blue))

⚠️ [Android Lint] _{reported by reviewdog 🐶}
WearRecents: Set taskAffinity for Wear activities to make them appear correctly in recents

organicmaps/android/wear/src/main/AndroidManifest.xml

Line 17 in 668cef2

<activity

Use the bundled timezone database for DST tests and a startup language override for desktop tools. Avoid mutating process environment variables and adding Windows CRT compatibility shims. Signed-off-by: Alexander Borsuk <me@alex.bio>

Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

Use /fp:fast to match other platforms behavior. Set /bigobj to prevent possible linking errors with static libraries. Only add these flags for C and C++ to remove warnings when compiling ASM code. Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

This namespace was conflicting with a type name in boost::mp11. Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

Osyotr marked this pull request as draft July 28, 2025 21:16

Osyotr force-pushed the windows-lite branch 2 times, most recently from 36f706e to cfd5285 Compare July 28, 2025 21:54

Osyotr force-pushed the windows-lite branch 3 times, most recently from 9c404c1 to 7d71c77 Compare August 10, 2025 16:22

Osyotr force-pushed the windows-lite branch 9 times, most recently from db1e745 to 1cab00a Compare October 19, 2025 19:49

Osyotr force-pushed the windows-lite branch 3 times, most recently from 8e5fdc6 to e73e331 Compare November 11, 2025 18:00

Osyotr force-pushed the windows-lite branch from e73e331 to 29e7d2d Compare November 29, 2025 13:57

Osyotr force-pushed the windows-lite branch from 29e7d2d to c0e7532 Compare December 13, 2025 15:22

github-actions Bot reviewed Dec 13, 2025

View reviewed changes

Comment thread libs/drape/harfbuzz_shaping.cpp

Comment thread libs/transit/world_feed/feed_helpers.cpp

Comment thread libs/transit/world_feed/feed_helpers.cpp

Comment thread libs/transit/world_feed/feed_helpers.hpp

Comment thread libs/transit/world_feed/feed_helpers.hpp

Osyotr force-pushed the windows-lite branch from c0e7532 to 8f6772c Compare December 15, 2025 20:15

Osyotr force-pushed the windows-lite branch 4 times, most recently from 4929fe3 to 6ed03fb Compare February 7, 2026 15:06

Osyotr commented Mar 4, 2026

View reviewed changes

Osyotr force-pushed the windows-lite branch 2 times, most recently from 95da876 to cb41222 Compare March 15, 2026 16:56

Osyotr force-pushed the windows-lite branch from cb41222 to 668cef2 Compare July 7, 2026 21:56

github-actions Bot reviewed Jul 7, 2026

View reviewed changes

Osyotr force-pushed the windows-lite branch from 668cef2 to 3adc6eb Compare July 27, 2026 14:40

Osyotr force-pushed the windows-lite branch from 3adc6eb to 1f437af Compare August 19, 2026 23:05

Osyotr closed this Aug 19, 2026

Osyotr reopened this Aug 19, 2026

Osyotr force-pushed the windows-lite branch 4 times, most recently from d57e452 to a069f33 Compare September 6, 2026 20:34

biodranik and others added 8 commits September 6, 2026 22:53

[windows] Make language and DST overrides portable

95bfbff

Use the bundled timezone database for DST tests and a startup language override for desktop tools. Avoid mutating process environment variables and adding Windows CRT compatibility shims. Signed-off-by: Alexander Borsuk <me@alex.bio>

Fix compilation errors on Windows

e7fefd8

Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

Adjust compilation flags for MSVC

07ae49b

Use /fp:fast to match other platforms behavior. Set /bigobj to prevent possible linking errors with static libraries. Only add these flags for C and C++ to remove warnings when compiling ASM code. Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

Use ExternalProject to fetch world_feed_integration_tests_data

7cd020a

Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

Add Windows action

01ff357

Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

Fix unity build on windows

e4c2948

This namespace was conflicting with a type name in boost::mp11. Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

Add ci-windows preset

8d9ab3b

Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

Run ctest in bash

b28ba22

Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

Osyotr force-pushed the windows-lite branch from a069f33 to b28ba22 Compare September 6, 2026 21:03

Osyotr closed this Sep 19, 2026

Osyotr deleted the windows-lite branch September 30, 2026 13:40

Navigation Menu

Repository navigation

WIP Windows lite - #2

WIP Windows lite#2
Osyotr wants to merge 8 commits into
masterfrom
windows-lite

Osyotr commented Jul 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Osyotr Mar 4, 2026

Uh oh!

github-actions Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Osyotr commented Jul 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Osyotr Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants