Improve exception string formatting#423
Open
lovewave02 wants to merge 1 commit into
Open
Conversation
Author
|
Python 3.12 is timing out in the existing integration suite, while 3.8, 3.11, I also compared that test on the PR head and the pre-change commit in the same Could you rerun the Python 3.12 job when convenient? I haven't pushed a |
Member
|
Thanks for the interest and PR. Changes look good, will retry the test on CircleCI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Exceptions such as
AuthenticationErrorkeep a printf-style message and itsvalues in
args, so their default string output currently looks like a tuple.This adds a shared string representation that formats those values while
leaving
argsunchanged. Single-argument exceptions keep their existingoutput, and invalid formats fall back to Python's normal exception formatting.
The behavior is covered by regression tests and documented in the exceptions
reference.
Verification
pytest(21 passed)flake8 psshflake8 tests ci/integration_testspython setup.py check --restructuredtextpython setup.py sdist bdist_wheelorigin/master)Resolves #404