Repository navigation
create-dev-identity - honor izuma.io special case for myriplane addr - #68
Merged
Merged
Conversation
The d) and m) option cases assigned MYRIPLANE_ADDR directly, which ran before and shadowed the centralized derivation block, so the izuma.io special case (stargate.staging.izuma.io) was never applied when the address was set via -m .izuma.io (the path used by generate-identity.sh). Remove the assignments from d) and m) so the derivation block is the single source of truth for MYRIPLANE_ADDR. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fix to #67. When the identity was generated via
-m .izuma.io(the pathgenerate-identity.shuses), the resultingidentity.jsoncontainedhttps://myriplane.izuma.ioinstead of the intendedhttps://stargate.staging.izuma.io.Root cause: the
d)andm)option cases assignedMYRIPLANE_ADDRdirectly, so the centralized derivation block (which holds theizuma.iospecial case) was skipped because it only runs whenMYRIPLANE_ADDRis empty.Fix: remove the
MYRIPLANE_ADDRassignments fromd)andm)so the derivation block is the single source of truth.Test plan
-m .izuma.io→https://stargate.staging.izuma.io✅ (previouslyhttps://myriplane.izuma.io)-d→https://myriplane.us-east-1.mbedcloud.com-m .example.com→https://myriplane.example.com-s <addr>override → wins🤖 Generated with Claude Code