Skip to content

fix playground enforcement tab - #3204

Merged
omer-topal merged 1 commit into
masterfrom
fix-playground-enforcement-tab
Sep 11, 2026
Merged

omer-topal merged 1 commit into
masterfrom
fix-playground-enforcement-tab

Conversation

@omer-topal

@omer-topal omer-topal commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Preserved editor text while it is being edited, including equivalent or temporarily invalid YAML.
    • Updated the editor only when scenario changes occur outside the editor.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 1b4c2575-a8c2-4519-843d-b50513acec71

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 4ab48bd and 8b7e0c7.

πŸ“’ Files selected for processing (1)
  • playground/src/features/enforcement/enforcement.jsx

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


πŸ“ Walkthrough

Walkthrough

The enforcement editor now preserves raw YAML input while parsing changes into scenarios. Synchronization replaces editor text only when scenarios change externally.

Changes

YAML editor synchronization

Layer / File(s) Summary
Editor state and scenario synchronization
playground/src/features/enforcement/enforcement.jsx
handleYamlChange stores raw editor text before parsing. The synchronization effect preserves equivalent or invalid YAML and applies dumped scenarios only after external scenario changes.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: βšͺ Minimal Β· up to 8b7e0

The editor now retains in-progress and invalid YAML without introducing an identified user-facing synchronization regression.

πŸš₯ Pre-merge checks | βœ… 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
βœ… Passed checks (4 passed)
Check name Status Explanation
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check βœ… Passed The title identifies the enforcement tab fix, which matches the main change in the pull request.
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches πŸ’‘ 2
πŸ“ Generate docstrings πŸ’‘
  • Create stacked PR
  • Commit on current branch
πŸ› οΈ Fix failing CI checks πŸ’‘
  • Create stacked PR
  • Commit on current branch
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-playground-enforcement-tab

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 76.29%. Comparing base (4ab48bd) to head (8b7e0c7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3204   +/-   ##
=======================================
  Coverage   76.29%   76.29%           
=======================================
  Files          83       83           
  Lines        9215     9215           
=======================================
  Hits         7030     7030           
  Misses       1635     1635           
  Partials      550      550           

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@omer-topal
omer-topal merged commit 7529af5 into master Sep 11, 2026
12 of 14 checks passed
@omer-topal
omer-topal deleted the fix-playground-enforcement-tab branch September 11, 2026 14:53
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant