fix: synchronize sleep-spam tracking state#230
Open
hedssaz wants to merge 1 commit into
Open
Conversation
Author
|
Stress-tested the synchronized tracking path with 256 concurrent pthreads over 20 rounds (517,120 calls), plus a Thread Sanitizer run with 64 threads over 10 rounds (64,640 calls): no crashes or data races were reported, and every thread remained below the threshold for calls 1–100 and crossed it exactly on call 101. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
pt_usleepcan run concurrently on multiple game threads whileblockSleepSpammingis enabled. The sharedNSMutableDictionaryinstances were read and mutated without synchronization. Concurrent access could corrupt their internal storage during insertion or rehashing and crash the game frompt_usleep.Impact
This preserves the existing sleep-spam detection behavior while preventing dictionary access races during game startup and runtime.
Testing