Add CI: shellcheck, Python syntax, manifest and compose validation - #19
Open
divyanshus2404 wants to merge 1 commit into
Open
divyanshus2404 wants to merge 1 commit into
divyanshus2404 wants to merge 1 commit into
Conversation
The repository has no continuous integration; contributions are currently checked only by manual review, if at all. This adds a lightweight GitHub Actions workflow that runs on every pull request and on pushes to main. Four jobs, each green on the current tree: - shell: shellcheck (-S error) over every tracked *.sh / *.command - python: py_compile over all tracked *.py (blocking), plus ruff (informational) - manifests: validates every ai-agents/*/plugin.json and service-providers/*/provider.json parses and carries its required fields - compose: validates docker-compose*.yml is well-formed YAML, tolerating Compose's !override / !reset tags The manifest validator also surfaces two existing issues as non-blocking warnings: ai-agents/upwork has no entrypoint, and ai-agents/apollo.io has plugin_id "apollo" (directory/id mismatch). These are flagged, not failed, so CI stays green while the inconsistencies are visible. shellcheck runs at -S error because the existing scripts are clean at that severity but have style-level warnings; the threshold can be tightened once those are addressed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The repository has no continuous integration. Every PR (including the agent integrations already open) is checked only by manual review, if at all. This adds a lightweight GitHub Actions workflow that runs on each pull request and on pushes to
main.Four jobs, each verified green against the current tree:
shellcheck -S errorover every tracked*.sh/*.commandpy_compileover all tracked*.py(blocking) +ruff(informational)ai-agents/*/plugin.jsonandservice-providers/*/provider.jsonparses and has its required fieldsdocker-compose*.ymlis well-formed YAML, tolerating Compose's!override/!resettagsVerified locally against the current tree
shellcheck -S error: 6 scripts, 0 errorspy_compile: 137 Python files, 0 syntax errorsSo the workflow is green on merge, not red-on-arrival.
Two existing issues surfaced (as warnings, non-blocking)
The manifest validator flags these without failing CI, so they are visible but do not block:
ai-agents/upwork/plugin.jsondeclares noentrypointai-agents/apollo.io/plugin.jsonhasplugin_id: "apollo"— directory/id mismatchNotes
shellcheckruns at-S errorbecause the existing scripts are clean at that severity but carry style-level warnings (49 at default). The threshold can be tightened towarningonce those are cleaned up.ruffis informational (continue-on-error) so existing style does not block, while still surfacing suggestions..github/scripts/and can be run locally:python3 .github/scripts/validate_plugins.py.This is intentionally a fast, dependency-light first layer. A natural next step is a stack smoke-test (
docker compose up, assert the app answers) — that would catch runtime regressions the static checks cannot.🤖 Generated with Claude Code