Implement Oklahoma Unemployment Insurance (ref #8264) - #8265
Implement Oklahoma Unemployment Insurance (ref #8264)#8265daphnehanse11 wants to merge 10 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8265 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 11 +8
Lines 49 142 +93
=========================================
+ Hits 49 142 +93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Replace broken 2025 OESC PDF URL with working OMES PDF + OESC homepage - Fix section citation: §1-218 → §1-201(48) + §1-223 in taxable_wage_base - Add subsection specificity: §2-207(A) → §2-207(A)(1)/(A)(2) - Correct PDF page anchors: divisor/min_amount/max_amount #page=49→50; disregard #page=50→51 - Update stale $27,400 test comments to match actual $27,000 param - Replace 0000-01-01 sentinel with 1980-07-01 in mba/max_weeks - Add trailing comma to make single-element reference tuples valid Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Change 0000-01-01 sentinel to 2024-01-01 in taxable_wage_base - Replace repealed §1-202 with current §1-201(4) in base-period docstrings - Add §2-207 reference to ok_ui_base_period_total_wages (where "total wages" qualifier comes from) - Update §2-104(B) title in max_amount to clarify OESC Board determination Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Remove the adds wiring into unemployment_compensation (newer core rejects adds combined with uprating, and the integration is deferred to PolicyEngine#8303 pending policyengine-us-data support) and the coupled integration assertion. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Rebased onto current main (branch is now main + 6 commits). One substantive change during the rebase: the |
Program Review — via /review-program (multi-agent audit)PR: #8265 — Oklahoma Unemployment Insurance (new program, OK, 2022–2026) Source Documents
All five primary PDFs were fetched and text-extracted; every 2022–2026 dollar value was checked against them (see Source Audit Summary). Branch Status⚠ PR branch is 41 commit(s) behind main. Consider rebasing before merge. Review scoped to merge-base diff; staleness did not affect findings. Critical (Must Fix)
Should Address
Suggestions
Source Audit Summary
The reference validator's inability to machine-read the OESC bulletins (S1 in its report) was superseded by the PDF audit, which fetched and read all of them — every 2022–2026 dollar value is now source-corroborated. Remaining open reference risks are the page anchors (Critical 3–4) and the HB3596 question (Should Address 2). Validation Summary
Review Severity: REQUEST_CHANGESFive critical findings — one confirmed regulatory value error active in a claimed/tested year (2022 MBA cap), one cross-program parameter-history regression, two citation-integrity blockers, and one test-structure violation — require changes before merge. The core program logic is otherwise sound and thoroughly source-verified. Next Steps
🤖 Generated by /review-program (Claude Code multi-agent review) |
…tests - Set 2022 base-period wages share to 0.4 (conditional factor D per 40 O.S. 2-106(3) and the OESC table); pre-2023 uncapped value was incorrect and overstated 2022 MBAs - Restore the pre-existing 0000-01-01: 27,000 taxable wage base anchor the PR had dropped, keeping pre-2022 OK payroll tax identical to main - Reconcile every os40.pdf page anchor to verified file pages; add stable OSCN per-section HTML references and HB 3596 citation for the 16-week duration; strip page numbers from reference titles - Document the taxable-wage proxy in the 1.5x eligibility test, the 16x-max-WBA proxy for the 2-106(2) cap, the calendar-year wage-base cap, the unmodeled duration escalator, and microsim-inert inputs - Guard maximum benefit amount against negative wages with max_(.., 0) - Dissolve the aggregate edge_cases.yaml into per-variable test files and add boundary tests (2026 wage-base step, WBA clamps, binding MBA caps by year, 16-week seam, negative wages) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes Applied (from Program Review)Commit 68139b5 addresses all actionable findings from the review above. Critical
Should Address
Suggestions
Skipped (deliberate)
Verification
🤖 Applied via |
Program ReviewPR #8265 — "Implement Oklahoma Unemployment Insurance (ref #8264)", author Source Documents
Branch StatusThe branch is 8 commits ahead and 325 commits behind Staleness did not affect any finding in this review: the review was scoped to the merge-base diff, every file examined is either new in this PR or was read at PR head, and all three parameter-value verifications were run against external primary sources rather than against base-branch state. This note is informational only and is not a finding. Critical (Must Fix)
Should Address
Suggestions
Investigated and ClearedNine reported mismatches were escalated to Phase 5 verification and rejected. None appears as a finding.
Additional clean results worth recording, so they are not re-flagged:
Pre-existing IssuesNot introduced by this PR; excluded from the critical count and from the severity recommendation.
PDF Audit Summary
Reference-checker corroboration table, all 25 in-scope parameter values: 19 CORROBORATED (6 of them through a mis-anchored citation — [C2]), 5 corroborated-value / uncorroborated-date ([S6]), 1 uncorroborated by cited sources (2022 share — closed by [A4]), 1 CONTRADICTED (the pre-existing pre-2022 sentinel). Anchor audit: 49 added Validation Summary
Review Severity: REQUEST_CHANGESThis is a well-built implementation and much of it verified clean: all three § 2-106 prongs are correctly nested, the § 2-105 partial-benefit formula is exact, every 2022–2026 annual value matches an OESC publication to the dollar, no legal value is hard-coded, no variable is reinvented, every formula-bearing variable has tests, and CI is green. Four of the five reported "value mismatches" that reached verification were rejected on the evidence, including both of the two that would have been most damaging. The blocking item is [C1]: § 2-207(A)(2)'s multiplicand is the capped taxable figure where the statute says bare "wages", which flips Next StepsTo auto-fix issues: run the fix-pr workflow for this PR. |
…on citations Correct the base_period_wages_share comment so 40% maps to factor (e) and 47.5% to (b) (was 'd'/'a'); the 0.4/0.475 values are unchanged. Add section labels (§1-201/§1-218/§2-207, §1-223) to the previously bare os40.pdf page anchors on the two base-period wage variables. Documentation only, no value or logic change — OK suite 328/328 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Fixes Applied — remaining review itemsFollowing up on the earlier fix round (commit Fixed
Verification
Everything from the program review is now addressed. 🤖 Generated with Claude Code |
…x citations - C1 (behavioral): the §2-207(A)(2) high-quarter eligibility multiplier read capped TAXABLE wages, wrongly passing an ineligible claimant. Add a ok_ui_high_quarter_total_wages input and apply the 1.5x prong to total wages per the statute; remove the false Test-B-rescue docstring. Add a divergence test that inverts if reverted, plus MBA-binding and 2023/2026 end-to-end cases. - C2: correct the os40.pdf #page anchors across the MBA/WBA/wage-base refs and the base-period wage variables (values were already right). - A5-A10: taxable_wage_base §1-223 vintage note; drop the stale handbook Rev-05-2025 label and the 'OESC Board determines' phrasing; correct max_weeks' §1-231 attribution (Laws 2022 c.287) and reframe the escalator as operative- but-non-binding; disclose the employer payroll-tax effect in the changelog; guard weeks_unemployed with max_(...,0); reference cleanups. No parameter value changed. OK UI suite 335/335 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Fixes applied from @hua7450's reviewIncorporated the review above (pushed just now, OK UI suite 335/335 pass). Unlike the NY PR's C1, this C1 had one correct answer per statute, so it's fixed rather than deferred. C1 — the real output bug (fixed)The §2-207(A)(2) high-quarter eligibility prong was reading capped taxable high-quarter wages, but the statute uses total "wages" — which, as you showed, let an ineligible claimant through (~$6,112). Added an Citations / comments (values were already correct — no parameter value changed)
I left 🤖 Generated with Claude Code |
Summary
Implements Oklahoma Unemployment Insurance (administered by the Oklahoma Employment Security Commission, OESC).
Closes #8264
Regulatory authority
Monetary eligibility (§2-207)
A claimant is monetarily eligible if EITHER:
Annual taxable wage base
Weekly benefit amount (§2-104)
Maximum benefit amount (§2-106, HB 1933)
Partial benefits (§2-105)
Annual benefit
ok_ui_monetarily_eligibleand Oklahoma state codeRequirements coverage
Not modeled
30 NOT-MODELED items, listed in the scope decision. The most notable:
Historical notes
Files added