Repository navigation
[newton_method] Some updates - #1073
Open
longye-tian wants to merge 6 commits into
Open
longye-tian wants to merge 6 commits into
longye-tian wants to merge 6 commits into
Conversation
longye-tian
added
enhancement
23 tasks done
📖 Netlify Preview Ready!Preview URL: https://pr-1073--sunny-cactus-210e3e.netlify.app Commit: 📚 Changed LecturesBuild Info
|
longye-tian
removed
the
do-not-merge
longye-tian
marked this pull request as ready for review
September 28, 2026 00:29
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to one lecture file, and all code renames, the Jacobian correction, and parameter threading were traced and verified to be consistent and correct.
0 open findings
What changed in this PR
This PR revises the newton_method lecture to improve wording, notation, and code clarity/correctness in response to issue #1063. It fits into the QuantEcon intermediate Python lecture series as an educational content and code-quality improvement, with no structural or build changes.
Changes:
- Wording/notation polish: non-uniqueness phrasing ("a fixed point"/"a zero"), sentence-case headings,
:=definitions, explicit non-degeneracy conditions (1-g'(x_t)≠0,f'(x_t)≠0, nonsingular Jacobian), clearer per-sentence paragraphs, and corrected initial-vector notation ($k_0^{(i)}$ ,$p_0^{(i)}$ ). - Code correctness/clarity: fixed the hand-computed Jacobian to use full
(Ap)_irow products; computedk_starinsideplot_trajectories; parameterizedplot_excess_demandwithA, b, cviatwo_good_params; set the zero contour color to black and removed the misleading embedded title. - Renamed the multivariate Newton routine to
newton_nd(distinct from the scalarnewton) and updated all downstream calls; aligned "3,000 goods" prose with the code.
| File | Description |
|---|---|
| lectures/newton_method.md | Wording/notation refinements, a corrected hand-coded Jacobian, parameterized plotting, and a newton → newton_nd rename with consistent downstream call updates. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @jstac
This PR updates the lecture
newton_methodaccording to #1063Best,
Longye