Skip to content

Skip Developer ID checks when notarization is disabled #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afarchy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Skip Developer ID checks when notarization is disabled #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 19 additions & 17 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123585,24 +123585,26 @@ async function GetProjectDetails(credential, xcodeVersion) {
projectRef.isSteamBuild ||
projectRef.archiveType === 'pkg' ||
projectRef.archiveType === 'dmg';
let output = '';
await (0, exec_1.exec)('security', [
'find-identity',
'-v', projectRef.credential.keychainPath
], {
listeners: {
stdout: (data) => {
output += data.toString();
if (projectRef.notarize) {
let output = '';
await (0, exec_1.exec)('security', [
'find-identity',
'-v', projectRef.credential.keychainPath
], {
listeners: {
stdout: (data) => {
output += data.toString();
}
},
silent: true
});
if (!output.includes('Developer ID Application')) {
throw new Error('Developer ID Application not found! developer-id-application-certificate input is required for notarization.');
}
if (projectRef.archiveType === 'pkg' || projectRef.archiveType === 'dmg') {
if (!output.includes('Developer ID Installer')) {
throw new Error('Developer ID Installer not found! developer-id-installer-certificate input is required for notarization.');
}
},
silent: true
});
if (!output.includes('Developer ID Application')) {
throw new Error('Developer ID Application not found! developer-id-application-certificate input is required for notarization.');
}
if (projectRef.archiveType === 'pkg' || projectRef.archiveType === 'dmg') {
if (!output.includes('Developer ID Installer')) {
throw new Error('Developer ID Installer not found! developer-id-installer-certificate input is required for notarization.');
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

41 changes: 22 additions & 19 deletions src/xcode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,27 +349,30 @@ export async function GetProjectDetails(credential: AppleCredential, xcodeVersio
projectRef.isSteamBuild ||
projectRef.archiveType === 'pkg' ||
projectRef.archiveType === 'dmg';
let output = '';

await exec('security', [
'find-identity',
'-v', projectRef.credential.keychainPath
], {
listeners: {
stdout: (data: Buffer) => {
output += data.toString();
}
},
silent: true
});

if (!output.includes('Developer ID Application')) {
throw new Error('Developer ID Application not found! developer-id-application-certificate input is required for notarization.');
}
if (projectRef.notarize) {
let output = '';

await exec('security', [
'find-identity',
'-v', projectRef.credential.keychainPath
], {
listeners: {
stdout: (data: Buffer) => {
output += data.toString();
}
},
silent: true
});

if (!output.includes('Developer ID Application')) {
throw new Error('Developer ID Application not found! developer-id-application-certificate input is required for notarization.');
}

if (projectRef.archiveType === 'pkg' || projectRef.archiveType === 'dmg') {
if (!output.includes('Developer ID Installer')) {
throw new Error('Developer ID Installer not found! developer-id-installer-certificate input is required for notarization.');
if (projectRef.archiveType === 'pkg' || projectRef.archiveType === 'dmg') {
if (!output.includes('Developer ID Installer')) {
throw new Error('Developer ID Installer not found! developer-id-installer-certificate input is required for notarization.');
}
}
}
}
Expand Down
Loading