Fixed warnings - #619
Merged
Merged
Conversation
stefanatwork
requested review from
johguenther and
svenwoop
and
a lite review from Copilot
August 18, 2026 09:37
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to eliminate compiler warnings across the codebase by addressing uninitialized variables, unused code, and incomplete switch handling.
Changes:
- Initialize an
STB_TEXTEDIT_CHARTYPElocal used instb_textedit_replace()to avoid uninitialized-variable warnings. - Remove unused Level Zero extension-query helper code from the SYCL RT HWIF builder path.
- Add a
defaultbranch in CPU model frequency selection to ensureswitchcompleteness.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tutorials/common/imgui/imgui_widgets.cpp | Initializes a local “empty string” value to avoid uninitialized-use warnings. |
| kernels/sycl/rthwif_embree_builder.cpp | Removes unused driver-extension helper code; (see comment re: newly unused variable). |
| kernels/common/device.cpp | Adds a default case in CPU model switch to silence enum-handling warnings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
svenwoop
previously approved these changes
Aug 18, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
tutorials/common/imgui/imgui_widgets.cpp:4442
- Initializing
STB_TEXTEDIT_CHARTYPEwith acharliteral ('\0') can still trigger sign/conversion warnings depending on whatSTB_TEXTEDIT_CHARTYPEmaps to (e.g.,ImWchar). Using value-initialization avoids any implicit char-to-wide conversions while keeping the intent the same.
STB_TEXTEDIT_CHARTYPE empty_string = '\0';
svenwoop
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.