Skip to content

Fixed warnings - #619

Merged
stefanatwork merged 4 commits into
masterfrom
sw/fix_warnings
Aug 19, 2026
Merged

Fixed warnings#619
stefanatwork merged 4 commits into
masterfrom
sw/fix_warnings

Conversation

@stefanatwork

Copy link
Copy Markdown
Collaborator

No description provided.

@stefanatwork stefanatwork added this to the 4.5 milestone Aug 18, 2026
@stefanatwork
stefanatwork requested review from johguenther and svenwoop and a lite review from Copilot August 18, 2026 09:37
@stefanatwork stefanatwork self-assigned this Aug 18, 2026
@stefanatwork stefanatwork added the cleanup Fixing warnings, whitespace, spelling, etc. label Aug 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to eliminate compiler warnings across the codebase by addressing uninitialized variables, unused code, and incomplete switch handling.

Changes:

  • Initialize an STB_TEXTEDIT_CHARTYPE local used in stb_textedit_replace() to avoid uninitialized-variable warnings.
  • Remove unused Level Zero extension-query helper code from the SYCL RT HWIF builder path.
  • Add a default branch in CPU model frequency selection to ensure switch completeness.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tutorials/common/imgui/imgui_widgets.cpp Initializes a local “empty string” value to avoid uninitialized-use warnings.
kernels/sycl/rthwif_embree_builder.cpp Removes unused driver-extension helper code; (see comment re: newly unused variable).
kernels/common/device.cpp Adds a default case in CPU model switch to silence enum-handling warnings.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread kernels/sycl/rthwif_embree_builder.cpp Outdated
svenwoop
svenwoop previously approved these changes Aug 18, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

tutorials/common/imgui/imgui_widgets.cpp:4442

  • Initializing STB_TEXTEDIT_CHARTYPE with a char literal ('\0') can still trigger sign/conversion warnings depending on what STB_TEXTEDIT_CHARTYPE maps to (e.g., ImWchar). Using value-initialization avoids any implicit char-to-wide conversions while keeping the intent the same.
                STB_TEXTEDIT_CHARTYPE empty_string = '\0';

@stefanatwork
stefanatwork merged commit 1b68540 into master Aug 19, 2026
13 checks passed
@stefanatwork
stefanatwork deleted the sw/fix_warnings branch August 19, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Fixing warnings, whitespace, spelling, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants