Skip to content

fix: accept numpy integer types as Parachute trigger #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhi-0203 wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

fix: accept numpy integer types as Parachute trigger #1116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rocketpy/rocket/parachute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from inspect import Parameter, signature
from numbers import Real

import numpy as np

Expand Down Expand Up @@ -351,7 +352,7 @@ def wrapper(p, h, y, sensors, u_dot):
return

# Numeric altitude trigger
if isinstance(trigger, (int, float)):
if isinstance(trigger, Real) and not isinstance(trigger, bool):
self._trigger_falling_only = True

def triggerfunc(p, h, y, sensors, u_dot): # pylint: disable=unused-argument
Expand Down