BUG: accept numpy integer parachute height triggers (#1106) - #1120
Closed
thatrandomasiandev wants to merge 1 commit into
Closed
BUG: accept numpy integer parachute height triggers (#1106)#1120thatrandomasiandev wants to merge 1 commit into
thatrandomasiandev wants to merge 1 commit into
Conversation
Use numbers.Real (excluding bool) so numpy.int* altitude triggers work like python ints/floats.
Member
|
duplicated #1116 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests//make lint) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.md— no action needed; an LLM workflow auto-updates it after mergeCurrent behavior
isinstance(trigger, (int, float))rejectsnumpy.int32/numpy.int64height triggers while acceptingnumpy.float64(which subclassesfloat).Fixes #1106
New behavior
Numeric altitude triggers use
numbers.Realexcludingbool, so numpy integer/float scalars are accepted. Bools still raiseValueError.Breaking change
Additional information
Focused unit tests added/extended; full slow suite not run in this contribution pass.