BUG: stop dict_generator from sampling initial_solution (#1109) - #1122
Open
thatrandomasiandev wants to merge 1 commit into
Open
Conversation
…m#1109) Generate stochastic samples from declared constructor inputs only, and validate StochasticFlight.initial_solution on construct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests//make lint) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.md— no action needed; an LLM workflow auto-updates it after mergeCurrent behavior
StochasticModel.dict_generatortreated every instance tuple/list as a stochastic input, so a 14-tupleinitial_solutioncrashed ('float' object is not callable) and list form silently sampled one element.Fixes #1109
New behavior
dict_generatorsamples only declared constructor stochastic inputs.StochasticFlightvalidatesinitial_solutionon construct and never puts it in the generated dict.Breaking change
Additional information
Focused unit tests added/extended; full slow suite not run in this contribution pass.