Skip to content

CI: keep per-matrix coverage artifacts and fail Codecov errors (#1088) - #1123

Open
thatrandomasiandev wants to merge 1 commit into
RocketPy-Team:developfrom
thatrandomasiandev:ci/1088-coverage-matrix-artifacts
Open

CI: keep per-matrix coverage artifacts and fail Codecov errors (#1088)#1123
thatrandomasiandev wants to merge 1 commit into
RocketPy-Team:developfrom
thatrandomasiandev:ci/1088-coverage-matrix-artifacts

Conversation

@thatrandomasiandev

Copy link
Copy Markdown

Summary

  • Give each pytest matrix leg a unique coverage artifact (coverage-${{ matrix.os }}-py${{ matrix.python-version }}) instead of overwriting a shared coverage name.
  • Rename each coverage.xml before upload so download-artifact merge-multiple: true can flatten all reports without clobbering identical basenames.
  • Download all coverage-* artifacts in CodecovUpload and upload the full set via Codecov's directory input.
  • Set fail_ci_if_error: true so Codecov upload failures fail CI.

Fixes #1088

Test plan

  • Confirm CI runs on this PR (workflow paths include .github/**)
  • Each of the 6 matrix legs uploads a distinct coverage-*-py* artifact
  • CodecovUpload downloads all six and uploads without silent overwrite
  • A simulated Codecov error would fail the job (fail_ci_if_error: true)

@Gui-FernandesBR
Gui-FernandesBR force-pushed the ci/1088-coverage-matrix-artifacts branch from 146679f to 0e6eb73 Compare August 12, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coverage: five of six matrix reports are discarded, and the upload cannot fail the job

2 participants