ENH: model unbonded solid-motor grain CM shift (#340) - #1138
Open
thatrandomasiandev wants to merge 2 commits into
Open
ENH: model unbonded solid-motor grain CM shift (#340)#1138thatrandomasiandev wants to merge 2 commits into
thatrandomasiandev wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SolidMotor(grains_bonded=True)(default preserves current fixed-grain / BATES behavior).grains_bonded=False, applies a first-order inertial packing model: grains pack against the aft (nozzle-side) face of the initial grain stack, so propellant CM shifts toward the nozzle asgrain_heightregresses:CM(t) = grains_center_of_mass_position - _csys * (n/2) * (h0 - h(t)). Parallel-axispropellant_I_11uses the packed pitch.grain_separation(spacers) is retained; only grain-height loss shortens the stack. Withonly_radial_burn=True, height is fixed so CM does not shift.Fixes #340
Follow-ups (out of scope)
grain_separation → 0when packing)Test plan
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 pytest tests/unit/motors/test_solidmotor.pygrains_bondedround-trips throughto_dict/from_dict