Reducing compiler warnings and splitting the flows - #5
Open
arcticlinux wants to merge 2 commits into
Open
Conversation
- Split the flows to silence compiler warnings and simplify methods - Don't redefine PI if it is already defined
- further compiler warning reductions by splitting flows - make sure functions return a default value to satisfy their definition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is there any interest in this sort of pull request?
I'm working in VSCode + Platformio and getting a few compiler warnings, so I decided to do a slight cleanup of the pieces of code giving warnings.
There might need to be some formatting changes/aligned (tabs, spaces, etc) if you wanted to merge something like this.
Warnings attached.
DabbleESP32-compiler_warnings.txt