-
Notifications
You must be signed in to change notification settings - Fork 4
Trend improvements #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Trend improvements #227
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
251bf84
Get the trend value for individual data.
jamescrake-merani 0893a69
Some docstrings for functions.
jamescrake-merani abf349b
If there's only zero, or one data, return true
jamescrake-merani f80f036
Move named trend into sasdata.
jamescrake-merani 4f1cb5c
Move this to the bottom.
jamescrake-merani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be true when
self.datais empty?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well in one sense, it is vacuously true since all the axes match if there is no data to check against.
It looks like Miguel already had a check to see if there are less than two value data remaining, but his only prints out a warning. We could change that into an error, but I'm inclined just to leave it for now.