Skip to content

Show notifications with Quasar's Notify plugin - #779

Open
apbendi wants to merge 1 commit into
withdraw-gas-price-from-providerfrom
quasar-notifications
Open

apbendi wants to merge 1 commit into
withdraw-gas-price-from-providerfrom
quasar-notifications

Conversation

@apbendi

@apbendi apbendi commented Oct 23, 2026

Copy link
Copy Markdown
Member

Replace bnc-notify with Quasar's built-in Notify plugin for the app's alerts and transaction notifications. Alerts keep their position and timeouts, and a transaction notification still shows while the transaction is pending and updates in place when it succeeds or fails. Each notification has a button to dismiss it, and transaction notifications link to the transaction in a block explorer.

Add tests for the alerts module.

@apbendi
apbendi added this pull request to stack #778 October 23, 2026 13:36
@netlify

netlify Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for jolly-shaw-20fe62 ready!

Name Link
🔨 Latest commit 8af7d0f
🔍 Latest deploy log https://app.netlify.com/projects/jolly-shaw-20fe62/deploys/6adc28c1f61227b31d27f1aa
😎 Deploy Preview https://deploy-preview-779--jolly-shaw-20fe62.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@apbendi
apbendi requested a review from mikeghen October 23, 2026 13:42
@apbendi
apbendi force-pushed the quasar-notifications branch from 5d9a9ba to df99752 Compare October 23, 2026 13:52
Replace bnc-notify with Quasar's built-in Notify plugin for the app's
alerts and transaction notifications. Alerts keep their position and
timeouts, and a transaction notification still shows while the
transaction is pending and updates in place when it succeeds or fails.
Each notification has a button to dismiss it, and transaction
notifications link to the transaction in a block explorer.

Add tests for the alerts module.
@apbendi
apbendi force-pushed the quasar-notifications branch from df99752 to 8af7d0f Compare October 24, 2026 03:40
@github-actions

Copy link
Copy Markdown

Coverage after merging quasar-notifications into withdraw-gas-price-from-provider will be

88.22%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts-periphery/src
   UmbraBatchSend.sol100%100%100%100%
   UniswapWithdrawHook.sol100%100%100%100%
umbra-js/src
   ethers.ts82.22%100%63.64%100%
umbra-js/src/classes
   KeyPair.ts98.54%97.62%100%98.75%248, 250
   RandomNumber.ts100%100%100%100%
   StealthKeyRegistry.ts100%100%100%100%
   TxHistoryProvider.ts85.19%65%100%96.55%12, 17, 20, 23, 29, 43, 48, 8
   Umbra.ts82.65%72.22%93.02%87.59%167–168, 189, 262–263, 331, 349–352, 388–389, 413, 428, 431, 438–440, 442, 449, 452, 452, 452–453, 460, 460, 460, 460, 460–461, 463–464, 494, 494, 494, 496, 496, 496, 498, 498, 498, 498–499, 499, 499–501, 517–518, 583–585, 62, 62, 626, 681, 685, 731, 744–745, 755–756, 770, 778–779, 809–810, 885–886, 889, 892–893, 899–901, 908, 908, 908–911, 946, 948–949, 949–950
umbra-js/src/utils
   constants.ts100%100%100%100%
   sharedSecret.ts83.05%72.73%100%87.88%24, 27–28, 42–43, 47–48, 62, 62–63
   utils.ts77.72%71.25%87.50%81.65%109–110, 1173–1174, 1186–1187, 135, 143, 143, 159–161, 163–165, 171, 193–194, 220–222, 222, 222–223, 223, 223, 304, 307, 312, 316, 320, 330, 342–347, 349–356, 356, 356, 356, 356, 356, 356–357, 359, 369, 400–402, 408, 418–419, 426–427, 434, 444, 444–445, 445–446, 451, 481–482, 491–492, 512–514, 527–528, 554–556, 565, 638, 645, 645–646, 646, 646–647, 647, 649, 653, 716, 718–719, 727–728, 746, 777, 799–801, 804, 814, 826, 826–827, 832, 834–835, 846–850, 863, 865, 916–917, 917, 917–919, 919, 919, 930
umbra-js/test
   testPrivateKeys.ts100%100%100%100%
   utils.ts100%100%100%100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant