refactor(surface): derive transports from operation descriptors - #1113
Open
ScriptedAlchemy wants to merge 7 commits into
Open
refactor(surface): derive transports from operation descriptors#1113ScriptedAlchemy wants to merge 7 commits into
ScriptedAlchemy wants to merge 7 commits into
Conversation
…plan-reopened' into sol/operation-surface-1087-1091
…plan-reopened' into sol/operation-surface-1087-1091
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d662830e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+67
to
+70
| input_schema: application_input_schema( | ||
| operation, | ||
| executable.request_schema().body(), | ||
| ), |
There was a problem hiding this comment.
Projecting the raw schemars body makes tools/list advertise invalid Git read requests: the five Git read DTOs expose unconstrained Option<u32/u64> fields, so values such as max_entries: 0, max_entries: 1001, or max_bytes: 0 appear valid, while parse_git_read_surface_request still rejects anything outside 1..=1000 and 1..=4_194_304 (and similarly bounds history count). The removed git_read_bounds() projection advertised these limits and defaults, so schema-following MCP clients can now generate calls that admission rejects; encode these constraints in the canonical generated schema.
AGENTS.md reference: AGENTS.md:L138-L140
Useful? React with 👍 / 👎.
Contributor
Performance Comparison
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tracedecay_diagnostics_readnametracedecay_diagnosticsMCP/CLI request through one edge adapter; 13 existing plugin bundles use that contractsession_lookupSDK MCP transport and methodResults
Tests
dashboardcontracts checkBase-only observation
cli_non_interactive_test::branch_list_reads_profile_sharded_branch_metaprints its complete expected output and then hangs for 90 seconds. The same exact non-vacuous command reproduces identically on the current #707 base, so this PR does not alter it.Closes #1087.
Closes #1091.