fix(graph): bind builder callers through typed locals (#1355) - #1371
Closed
ScriptedAlchemy wants to merge 1 commit into
Closed
ScriptedAlchemy wants to merge 1 commit into
ScriptedAlchemy wants to merge 1 commit into
Conversation
Carry the closed #1361 lexical LocalTypeScope redesign onto a fresh campaign-tip lane, and address remaining Codex P1s: resolve import aliases when matching Type::method owners, verify local new return types before qualifying bindings, and accept inline module segments. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
builder.build()through a typed local emitsWalkBuilder::buildand seals a realCallsedge instead of a complete-looking empty callers set.codex/tracedecay-total-redesign-plan-reopened).Motivation
Tip
aeb2b5c35still reproduces the class-1 miss: barebuildis blocklisted and the dotted receiver is dropped, so callers look complete with zero edges. Measured tip repro is in the agent store (internal/issue-1355/tip-repro-extraction.log,1361-closed-unmerged.md).Changes
rust_extractor.rs): lexicalLocalTypeScope;mut/refbinding unwrap;Type::new-only inference; when a localnewmethod exists, require returnSelf/type (abstain forFactory::new() -> Product); cross-filenewkeeps the convention.helpers.rs):associated_type_method_matchesforType::method; resolve import aliases (use dep::WalkBuilder as Builder→ ownerWalkBuilder); module-segment + inline-module path matching.new/annotation cases.Test plan
mut_builder_local_*,new_with_non_self_return_*, shadow/annotation suitecross_file_builder_method_calls_bind_through_typed_locals,cross_file_aliased_builder_method_calls_bind_through_typed_localstest-transport):callers_of_cross_file_builder_method_include_typed_local_sitesChecklist
CHANGELOG.mdupdated (under[Unreleased]if no version bump).envfiles includedMerge remains Zack’s call.
Closure decision (2026-09-16)
Closed unmerged. This replacement is larger than #1361 (+1090/−71) and still retains convention-based cross-file
Type::new()inference without canonical return-type evidence, plus the reviewed local-scope/path-matching complexity. It therefore repeats the unsafe architecture instead of using existing signature/import/type authorities. #1355 remains open. Next step is read-only authority mapping, followed by a smaller fix that proves receiver type or abstains.