Skip to content

test(search-eval): re-pin query-fallback digests after lexical change - #1425

Merged
ScriptedAlchemy merged 1 commit into
codex/tracedecay-total-redesign-plan-reopenedfrom
cursor/863-search-eval-repin-13ea
Sep 16, 2026
Merged

ScriptedAlchemy merged 1 commit into
codex/tracedecay-total-redesign-plan-reopenedfrom
cursor/863-search-eval-repin-13ea

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Sep 16, 2026 •

Copy link
Copy Markdown
Owner

Summary

#863 search-eval digest re-pin rebased onto tip bcbac206bc (clears shared Format/Clippy stale-base noise). Conflict resolved as tip workload JSON + PR digest pins + matching WORKLOAD_SHA256. Rustfmt commit clears tip-inherited Format drift.

CI-only

Product scope unchanged (digest re-pin only). Freeze #1428 stays closed. #1453 left pending-only.

Test plan

  • Rebase onto tip; resolve packaged pin against tip JSON
  • cargo fmt --all -- --check clean
  • Hosted CI Format/Clippy green on new head
Open in Web Open in Cursor 

@changeset-bot

changeset-bot Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0f05d6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-16T09:58:24.269100Z 801a98b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Performance Comparison codex/tracedecay-total-redesign-plan-reopened → cursor/863-search-eval-repin-13ea

Total Elapsed Time: 7.40s → 7.11s (-3.9%)
CPU Baseline: 70.81µs → 70.61µs (-0.3%)
Benchmark ID: index-bench-timing

timing - Execution duration of functions.

+--------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| Function                                   | Calls                      | Avg                             | P95                             | Total                            | % Total                      |
+--------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| tracedecay-index-bench                     | 1 → 1 (+0.0%)              | 7.40s → 7.11s (-3.9%)           | 7.40s → 7.11s (-3.9%)           | 7.40s → 7.11s (-3.9%)            | 100.00% → 100.00% (+0.0%)    |
+--------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| code_index.workers.install                 | 30 → 30 (+0.0%)            | 72.90ms → 64.59ms (-11.4%)      | 211.55ms → 233.05ms (+10.2%)    | 2.19s → 1.94s (-11.4%)           | 29.56% → 27.26% (-7.8%)      |
+--------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.batch.sqlite                | 5 → 5 (+0.0%)              | 392.40ms → 381.84ms (-2.7%)     | 436.47ms → 428.08ms (-1.9%)     | 1.96s → 1.91s (-2.6%)            | 26.52% → 26.86% (+1.3%)      |
+--------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| domain.canonical.sha256                    | 72891 → 72891 (+0.0%)      | 31.33µs → 25.64µs (-18.2%)      | 83.20µs → 83.71µs (+0.6%)       | 2.28s → 1.87s (-18.0%)           | 30.86% → 26.30% (-14.8%)     |
+--------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.finalization.advance_wake   | 28 → 28 (+0.0%)            | 48.01ms → 48.07ms (+0.1%)       | 397.41ms → 392.17ms (-1.3%)     | 1.34s → 1.35s (+0.7%)            | 18.17% → 18.94% (+4.2%)      |
+--------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.batch.postings              | 5 → 5 (+0.0%)              | 228.84ms → 228.37ms (-0.2%)     | 256.64ms → 257.95ms (+0.5%)     | 1.14s → 1.14s (+0.0%)            | 15.47% → 16.07% (+3.9%)      |
+--------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.batch.parallel_prepare      | 5 → 5 (+0.0%)              | 176.92ms → 175.15ms (-1.0%)     | 211.55ms → 233.05ms (+10.2%)    | 884.59ms → 875.77ms (-1.0%)      | 11.96% → 12.32% (+3.0%)      |
+--------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| code_index.build.and_publish               | 2 → 2 (+0.0%)              | 506.56ms → 434.17ms (-14.3%)    | 937.95ms → 802.16ms (-14.5%)    | 1.01s → 868.35ms (-14.0%)        | 13.69% → 12.22% (-10.7%)     |
+--------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| code_index.extract.parser_artifact         | 276 → 276 (+0.0%)          | 3.39ms → 3.02ms (-10.9%)        | 7.04ms → 4.83ms (-31.4%) 🚀     | 935.25ms → 832.14ms (-11.0%)     | 12.64% → 11.71% (-7.4%)      |
+--------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| domain.canonical.json_bytes                | 206681 → 206681 (+0.0%)    | 3.94µs → 3.70µs (-6.1%)         | 3.44µs → 3.35µs (-2.6%)         | 815.41ms → 765.72ms (-6.1%)      | 11.02% → 10.77% (-2.3%)      |
+--------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| query.artifact.batch.postings.ngram_rows   | 5 → 5 (+0.0%)              | 130.59ms → 129.04ms (-1.2%)     | 145.88ms → 145.49ms (-0.3%)     | 652.96ms → 645.20ms (-1.2%)      | 8.83% → 9.08% (+2.8%)        |
+--------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| code_index.restore.file_admit              | 260 → 260 (+0.0%)          | 3.24ms → 2.43ms (-25.0%) 🚀     | 6.71ms → 3.98ms (-40.7%) 🚀     | 842.45ms → 631.67ms (-25.0%) 🚀  | 11.39% → 8.89% (-21.9%) 🚀   |
+--------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| code_index.build.materialize_full          | 1 → 1 (+0.0%)              | 634.55ms → 550.93ms (-13.2%)    | 634.91ms → 551.03ms (-13.2%)    | 634.55ms → 550.93ms (-13.2%)     | 8.58% → 7.75% (-9.7%)        |
+--------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| code_index.collect.materialize_full        | 1 → 1 (+0.0%)              | 626.74ms → 544.88ms (-13.1%)    | 627.05ms → 545.26ms (-13.0%)    | 626.74ms → 544.88ms (-13.1%)     | 8.47% → 7.67% (-9.4%)        |
+--------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| 🆕 query.artifact.batch.postings.term_rows | 0 → 5 (+100.0%) ⚠️         | 0.00ns → 88.84ms (+100.0%) ⚠️   | 0.00ns → 101.45ms (+100.0%) ⚠️  | 0.00ns → 444.22ms (+100.0%) ⚠️   | 0.00% → 6.25% (+100.0%) ⚠️   |
+--------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+
| 🗑️ query.artifact.batch.commit             | 5 → 0 (-100.0%) 🚀         | 94.92ms → 0.00ns (-100.0%) 🚀   | 105.97ms → 0.00ns (-100.0%) 🚀  | 474.58ms → 0.00ns (-100.0%) 🚀   | 6.41% → 0.00% (-100.0%) 🚀   |
+--------------------------------------------+----------------------------+---------------------------------+---------------------------------+----------------------------------+------------------------------+

Generated with hotpath-rs

@ScriptedAlchemy ScriptedAlchemy left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rspack-team-mode — tip 801a98b12c82

Outcome: packaged search-eval query-fallback digests re-pinned after lexical tip change; PR body lists observed digests and WORKLOAD_SHA256 matches the tip fixture blob (verified locally). Root-cause called out → expectation bump is admissible.

COMMENT.

@cursor
cursor Bot force-pushed the cursor/863-search-eval-repin-13ea branch 2 times, most recently from 86946d4 to bf96fce Compare September 16, 2026 20:37
Train/validation digests drifted after bounded lexical vocabulary landed
without updating the packaged workload. Re-pin both partitions and
WORKLOAD_SHA256 so hosted lanes stop failing the baseline report.

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@ScriptedAlchemy
ScriptedAlchemy force-pushed the cursor/863-search-eval-repin-13ea branch from bf96fce to 0f05d6a Compare September 16, 2026 22:17
@ScriptedAlchemy
ScriptedAlchemy merged commit 7d70208 into codex/tracedecay-total-redesign-plan-reopened Sep 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants