refactor(code-extraction): delete ts_provider language compat alias - #1452
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aacc41741b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Migrate remaining callers to try_language and remove the backward-compatible language() wrapper so the grammar lookup has a single public path. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
da95c94 to
eb07268
Compare
ScriptedAlchemy
left a comment
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
rspack-team-mode — tip eb072683e531
Outcome: deleting the ts_provider::language compat alias in favor of try_language is a clean ownership/name cleanup; call sites + docs updated. No semantic widen.
COMMENT.
8edb37a
into
codex/tracedecay-total-redesign-plan-reopened
2 participants
Summary
Deletes the explicit backward-compatible
ts_provider::language()alias and migrates remaining in-repo callers totry_language().Campaign #707 migrate-delete wave2 (principle: migrate callers then delete legacy APIs — no internal compat shims).
Changes
pub fn languagewrapper fromcrates/tracedecay-code-extraction/src/ts_provider.rstry_language(code-extraction tests + graph complexity suite)try_languageonlyNot in scope
from_legacy/ObservedMcpRoute::Legacy(live transport; redesign-sized)Legacy*formats /LegacyToolCompatibilityOwnerVerify
cargo test -p tracedecay-code-extraction --lib -- try_language— passnpm run lint:commit -- --from origin/codex/tracedecay-total-redesign-plan-reopened --to HEAD— passrg 'ts_provider::language\(' crates— 0 product matchesBase:
codex/tracedecay-total-redesign-plan-reopened@d2c9294089only (never master / #745).