Repository navigation
fix(received): use one selection checkbox for payment and export - #248
Merged
Atharva0506 merged 1 commit intoOct 7, 2026
Merged
Conversation
The Received Invoices table had two unlabeled checkbox columns, one for batch payment and one for bulk export, which looked like a duplicate. It now has one. Export Selected exports every selected invoice, and Pay Selected pays only the selected invoices that can still be paid, so paid, cancelled or mismatched invoices can stay selected for export without blocking a batch payment. Also removes the Batch Payment panel's own Export Selected menu. It exported the invoice open in the details drawer rather than the selection, so with no drawer open it only showed "No invoice selected".
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 16 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Atharva0506
marked this pull request as ready for review
October 7, 2026 10:54
Contributor
|
✅ Build successful! Build Size MetricsWorkflow run · commit 9612841 |
Contributor
🔍 PR Preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed Issues:
No separate issue: this is a small UI fix on the Received Invoices page, found while testing the Sepolia redeploy.
Screenshots/Recordings:
TODO: Received Invoices table before (two checkbox columns) and after (one column), plus the Export dialog with paid and unpaid invoices selected.
Additional Notes:
Problem
drawerState.selectedInvoice), not the selected rows. With no drawer open, it only showed "No invoice selected".Change
isInvoicePayable). Paid, cancelled or mismatched invoices can stay selected for export without blocking a batch payment, so the earlier "deselect unpayable invoices" guard is no longer needed.batchHasUnpayablestring.Testing
npm run lint,npm test(273/273) andnpm run buildpass locally.Known overlap: #234 also edits
ReceivedInvoice.jsx, so whichever PR merges second needs a rebase.AI Usage Disclosure:
Check one of the checkboxes below:
I have used the following AI models and tools: Claude Code (Claude Opus 5.5)
Checklist