Skip to content

Added print_state functionality - #17

Merged
Grayson3455 merged 1 commit into
mainfrom
task/16-printing
Feb 17, 2026
Merged

Grayson3455 merged 1 commit into
mainfrom
task/16-printing

Conversation

@lpapamanolis

@lpapamanolis lpapamanolis commented Feb 14, 2026 •

Copy link
Copy Markdown
Collaborator
  • Removed scattered print statements and replaced them with print_state() functions
  • Implemented box-drawing printing for structured output

Closes #16.

- Removed scattered print statements and replaced them with print_state() functions
- Implemented box-drawing printing for structured output
@lpapamanolis
lpapamanolis requested a review from ktbolt February 14, 2026 09:54
@lpapamanolis lpapamanolis self-assigned this Feb 14, 2026

@ktbolt ktbolt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpapamanolis Very good replacing the print statements with a logger !

I didn't see it but are there various levels of detail for the logging ? I think that most times users will not want to see very much logging information.

@lpapamanolis

lpapamanolis commented Feb 17, 2026 •

Copy link
Copy Markdown
Collaborator Author

@ktbolt I am planning to have 4 levels of detail: silent (no logging), warning (warnings only), info (default), debug (additional details for debugging). These are all already implemented in the CustomLogging class.

A lot of the scattered prints have already been replaced by the custom logger. Still some remain to be addressed in future issues.

Agreed that logging should be minimal. My plan for the info (default) logging level:

  1. Print initialized state at the start of the simulation (what this issue is about). This will give users an opportunity to doublecheck their input parameter file and provides a reference in the terminal about the simulation currently running.
  2. For each timestep, print single line with relevant columns (similar to svMultiphysics).

@Grayson3455
Grayson3455 merged commit 16b4e11 into main Feb 17, 2026
3 checks passed
@lpapamanolis
lpapamanolis deleted the task/16-printing branch February 17, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up printing during initialization

3 participants