Repository navigation
feat: updated function to get namespace with lister - #8
Merged
Merged
Conversation
Jose-Matsuda
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves # https://jirab.statcan.ca/browse/ZONE-496
Description of your changes:
Changes the way the namespace value is retrieved. Instead of using a regex on the email, it now reads the role bindings and matches those to the email.
This allows a one-to-one matching for the namespace value, where as previously there could be edge cases where two emails look the same but have a different domain, which would result in the same namespace value.
The changes introduces a lister to get the rolebindings to match for the email. This lister should include a caching mechanism to improve performance when getting the rolebindings.
Requirements: