Repository navigation
fix(compare): fresh input is lower-wins in the compare tally - #324
Merged
Merged
Conversation
Fresh input is the Yield denominator, so less input for the same output is the rewarded direction. compareTally, the ledger input row and the share card now agree (card's duplicate tally replaced by the shared function). Raw band labelled RAW · FLOW · TOTAL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
compareTally()counted 10 contests, with all 4 raw pillars as more-wins, including fresh input. Fresh input is the denominator of Yield (Υ = cache_read × output / input²), so using less of it for the same output is what the product rewards. Scoring more input as a win contradicted "Volume isn't Yield".lib/analytics/compare-facts.ts: fresh input is now LOWER-wins. Output, cache read and cache write stay higher-wins (volume).components/compare/CompareLedger.tsx: the Input row uses lower-wins for its winner and bar. The Raw band is labelled "Raw · Flow · Total".components/share/CompareMatchupCard.tsx: its private copy of the tally (which would have kept the old rule) is replaced by the sharedcompareTally.compareTally, so they follow automatically.deriveFactshas no input winner logic.CompareVersusis unused and has no input axis.MO§ES vs Kabir (live numbers from the task)
Input 25,766,329 vs 387,900; output 199.3M vs 192.0M; cache read 51,791.3M vs 50,412.5M; cache write 2,737.8M vs 939.2M; Kabir wins all 6 derived metrics.
Tests
__tests__/board/compare-tally-input.test.ts(3 cases, including the MO§ES vs Kabir shape).npx tsc --noEmitclean, eslint clean on changed files,npm run test:ui397 passed,npm test695 passed (4 skipped).Not done
🤖 Generated with Claude Code