Addition of objectContents and objectItem for #1851 - #2939
jamescummings wants to merge 11 commits into
Conversation
|
Just noting the relevance of this very significant contribution to the community request on #2904. Looking forward to the conversation next week! |
|
Error is that objectItem not allowed in egXML in that context. (Where do I update what is allowed in egXML?) |
| an <gi>msIdentifier</gi> element with fewer contraints on the order of its contents. The <gi>objectIdentifier</gi> may be more | ||
| or less detailed dependent on the needs of the encoder. In some cases an <gi>object</gi> may be used mostly as a common | ||
| reference point for multiple <gi>objectName</gi> elements to refer back to. In situations, one might provide more detailed | ||
| reference point for multiple <gi>objectName</gi> elements to refer back to. In such situations, one might provide more detailed |
There was a problem hiding this comment.
I would change "elements to refer back to" to "elements to point to", since "back" doesn't have any real context here.
There was a problem hiding this comment.
Done, but using <height>, <width>, and <depth>
| </msContents> | ||
| </objectContents> | ||
| <physDesc> | ||
| <p>The mask of Tutankhamun is 54cm x 39.3cm x 49cm. It is constructed from two layers of high-karat gold that |
There was a problem hiding this comment.
Might it be worth putting the dimensions in <dimensions> elements?
There was a problem hiding this comment.
Done (put comment in wrong place)
| <note>Recto: Eve, in similar anatomical realism as Adam, holding a small citrus fruit | ||
| (representing the forbidden fruit). Above her is a grisaille relief of Cain murdering | ||
| Abel. Verso: The top inner-left shutter shows the Cumaean Sibyl looking down towards | ||
| the Virgin, below is architectural detail of the room for the annunciation |
There was a problem hiding this comment.
Isn't that comma after "the Virgin" a comma splice?
| <p> | ||
| In a fuller context of a complete <gi>object</gi> element the benefit of including such classification information are more evident. | ||
| Where a <gi>locus</gi> is provided for the <gi>objectItem</gi> this must come first. | ||
| Below, a fully worked example of <objectName>The Ghent Altarpiece</objectName> illustrates a detailed <gi>objectContents</gi>. |
There was a problem hiding this comment.
Just flagging that I doubt the Guidelines build stylesheets will know what to do with <objectName> until we update. It could be converted to <q> in the TEI Lite that underlies the Glines.
There was a problem hiding this comment.
Sure, but that is true of lots of things. We should add some rules for how that turns into TEI Lite for all sorts of elements....
| of 12 distinct physical oak panels, eight of which are double-sided wings. Together, | ||
| they form an exhaustive and complex theological narrative visible in different | ||
| configurations when open or closed. The work is believed to have been primarily created | ||
| by Hubert van Eyck (d. 1426) and his brother Jan van Eyck (1441), it was unveiled on 6 |
There was a problem hiding this comment.
Another comma splice. Also, should there be a "d." before 1441?
There was a problem hiding this comment.
fixed this and a few other ones, I have a bad habit.
| <note>Recto: Adam, depicted with striking anatomical realism representing the fall of | ||
| man. Above him is a small grisaille relief of Cain and Abel's sacrifices. Verso: The | ||
| top inner-right shutter shows the Erythraean Sibyl and below architectural | ||
| detail.</note> |
There was a problem hiding this comment.
I think I'd say "...and architectural detail below."
There was a problem hiding this comment.
fixed in multiple places.
| Where a <gi>locus</gi> is provided for the <gi>objectItem</gi> this must come first. | ||
| Below, a fully worked example of <objectName>The Ghent Altarpiece</objectName> illustrates a detailed <gi>objectContents</gi>. | ||
|
|
||
| <egXML xmlns="http://www.tei-c.org/ns/Examples" xml:id="gi-objectContents-egXML-jc"> |
There was a problem hiding this comment.
Just flagging up that this is a very long example indeed. Do we have any preferences or norms for example length?
There was a problem hiding this comment.
Yeah, I wanted to do the full version, so I could then use parts of it in various places. Perhaps have full example on the Spec page and an abbreviated version of it in the chapter?
I prefer fully formed examples.
| </objectItem> | ||
| <objectItem n="5"> | ||
| <locus>Upper register, right-central fixed panel (recto only).</locus> | ||
| <classCode scheme="http://iconclass.org/" n="11H(JOHN THE BAPTIST)">11H(JOHN THE |
There was a problem hiding this comment.
(Applies to other contexts too:) Does the @n attribute content have to be reproduced in the text node of <classCode>?
There was a problem hiding this comment.
They are actually different things. (Or could be.) The @n attribute is really a @key for the iconclass (because @scheme is the general scheme and classCode doesn't have att.canonical.) I could make the text more descriptive, I suppose, to differentiate? ut the idea is that it is the human-readable form of the iconclass code (which sometimes contains text, sometimes doesn't)
There was a problem hiding this comment.
That seems a bit weird without explanation.
There was a problem hiding this comment.
I'll add some text in ND to explain.
| <provenance>The work escaped Calvinist iconoclasts in 1566 when it was dismantled and | ||
| hidden the cathedral tower and later moved to the town hall. It was taken to Paris and | ||
| exhibited at the Louvre after the French Revolution, being returned to Ghent in 1815 | ||
| after the Battle of Waterloo. The Diocese of Ghent pawned them in 1815, and not repaying |
There was a problem hiding this comment.
The switch from "it" to "they" jars here -- presumably "they" is "the panels"?
jamescummings
changed the title
6 participants
Adding objectContents, objectItem, updating guidelines prose and examples.
Can someone review this addition of objectContents and objectItem including some large examples. I've added spec files, and updated the ND chapter, including removing some warnings about object only having been recently added, and lack of objectContents like element. However, I may have forgotten to do something that is now required or maybe have some duplicate xml:ids on examples or something I've not spotted. (And the list of things to do may have changed since I last added new elements.) I'm not expecting it to be perfect on first go.