Issue 2840 mdh - #2959
Issue 2840 mdh#2959martindholmes wants to merge 6 commits into
Conversation
sydb
left a comment
sydb
left a comment
There was a problem hiding this comment.
Test itself is correct for what it is, and this passes tests locally. So all well and good. But I am a bit concerned that we (ATOP, let alone Council) have not discussed this constraint for <macroSpec> and <dataSpec> (not to mention <constraintSpec> and <paramSpec>) yet.
| <constraint> | ||
| <sch:rule context="tei:*[local-name() = ('elementSpec', 'classSpec', 'macroSpec', 'dataSpec')][not(@module)]"> | ||
| <sch:report test="true()" role="warning"> | ||
| The @module attribute will be required on *Spec elements after 2027-09-30. |
There was a problem hiding this comment.
Two thoughts:
- Probably better to use
<<sch:name/>>instead of “*Spec”, as normal users may never have been exposed to that phrasing, and some would (quite reasonably) presume that<schemaSpec>belongs to that group. - End-of-deprecation date seems a bit close, given that this is backwards-incompatible. It means at most two releases with deprecation, but more likely only one, and at worst (say, a release in Feb and another in Oct) none.
There was a problem hiding this comment.
Done. I made it <sch:name/> and other *Spec elements because it would be infuriating to hit one error on one spec element, fix it, then get the next one, and so on. At least this way you know what to look for when the first error shows up. Date is now 2028-06-30.
|
MH to merge dev into the branch, and fix the tests, and then Council says we can merge it. |
3 participants
No description provided.