Conversation
tuurma
approved these changes
Sep 22, 2026
tuurma
left a comment
tuurma
left a comment
Contributor
There was a problem hiding this comment.
thx for fixing the indenting
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #2972 , title says it all.
NOTE to reviewers — the changes to attList.xml were checked in accidentally (they were sitting in my directory after a meeting last month in which this code was being talked about). The change is only to whitespace, there is no change to the code. Since this code is tested in detest.odd (search for “no_duplicate_attrs”), I do not think you need to even look at it as long as it pasts tests.