Repository navigation
plan 0025: say why the camera picture is missing instead of a broken image - #446
Merged
Merged
Conversation
…image The camera stream is an MJPEG <img>. When it couldn't load, the viewer showed a broken-image icon and nothing else. The shell's diagnosis of the preview chain was lost too if it arrived while the player was still opening, because the error listener was only attached afterwards. The listener now shows an error that is already waiting when it attaches, and the <img> reports its own load failure (once per stream) with the shell's last message. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvZVzdby22Dei3U2UG6iWq
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Coverage SummaryLines: 60.63% (8467/13963) · Statements: 59.69% · Functions: 56.65% · Branches: 57.34% Per-file coverage
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
lapwing | b237b33 | Commit Preview URL Branch Preview URL |
Sep 26 2026, 05:02 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Dove · project thread
Summary
Before: a camera recording that fails to display shows a broken-image icon and nothing else. If LapWing reported what was wrong while the player was still opening, that message was dropped, because the error listener was only attached after the open finished.
After: an error LapWing already reported is shown as soon as the player is attached, and the
<img>reports its own load failure (once per stream) as a toast titled "The camera picture couldn't be shown", with LapWing's last diagnosis as the detail.How:
VideoPlayercheckscameraPlayer.lastErrorwhen it attaches the error listener, and adds anonErrorhandler on the MJPEG<img>. There is one new locale key (video:insta360.previewFailed), translated in all seven languages.This is the viewer half of getting the blank Insta360 playback diagnosed from the phone, without adb. The LapWing half is TheAngryRaven/LapWing (branch
claude/project-thread-9vcsxm).Related Issues
Follows LapWing #48.
Type of Change
Checklist
bun run lintpassesbun run typecheckpassesbun run test:runpasses (i18n parity + insta360 suites run locally)bun run buildsucceeds (left to CI)CHANGELOG.md)Notes for Reviewers
UI-only; there is no unit coverage because
VideoPlayer.tsxis outside the coverage scope.🤖 Generated with Claude Code
https://claude.ai/code/session_01NvZVzdby22Dei3U2UG6iWq
Generated by Claude Code