Fix ruleset metrics for single-class batches - #211
Open
Hanabi9248 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Hanabi <317387557+Hanabi9248@users.noreply.github.com>
github-actions
Bot
force-pushed
the
codex/single-class-ruleset-metrics
branch
from
September 11, 2026 15:35
62e2ac1 to
4541fba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compute_ruleset_metricscrashes on a batch where every prediction and label is positive (or every one is negative). Scikit-learn infers a 1x1 confusion matrix, while the function expects four cells.Pass both boolean labels explicitly so the returned counts keep their binary layout. The regression exercises real rules on four single-class batches; the two correctly classified cases fail before the fix.
On Windows with Python 3.11,
python -m unittest discover -s tests/rule_induction/trxf -t .completes successfully: 74 tests run, 1 skipped. This includes the metric, core rule, classifier and PMML export tests. The full ML suite was not run.