Conversation
bbpennel
requested changes
Aug 19, 2026
| "--everyone", "canViewMetadata", | ||
| "--authenticated", "canViewMetadata"}; | ||
| "--authenticated", "canViewMetadata", | ||
| "--on-campus", "canViewMetadata"}; |
Member
There was a problem hiding this comment.
I think every test is setting all three types of permissions together. We should have at least one test that does not provide an --on-campus flag at all, probably a method dedicated, to ensure that the default works as expected (no on campus). On campus shouldn't be required.
| testHelper.populateDescriptions("gilmer_mods1.xml"); | ||
| testHelper.generateDefaultPermissionsMapping(UserRole.canViewMetadata, UserRole.canViewMetadata); | ||
| List<Path> stagingLocs = testHelper.populateSourceFiles("276_182_E.tif", "276_183_E.tif", "276_203_E.tif"); | ||
| testHelper.generateDefaultPermissionsMapping(UserRole.canViewMetadata, UserRole.canViewMetadata, |
Member
There was a problem hiding this comment.
We should verify that the sip service behaves as expected when the on campus role is not set
…o not include --on-campus flag
…vice behaves as expected without on campus role set
bbpennel
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://unclibrary.atlassian.net/browse/BXC-5734
--on-campusoption to assign patron access permissions for theon_campusgroupPermissionsInfo,PermissionsService, andPermissionsValidator