Parameterized Priced Extension

[M4th942]

• create separate data structures
• add tests
• implement basic functions

[CLAassistant]

All committers have signed the CLA.

[mikucionisaau]

Suggested change

	class ParameterConstraint { public: std::vector<int> coeffs; };
	struct ParameterConstraint { std::vector<int> coeffs; };

[mikucionisaau]

Suggested change

	class Polyhedron { public: std::vector<ParameterConstraint> constraints; };
	struct Polyhedron { std::vector<ParameterConstraint> constraints; };

[mikucionisaau]

Suggested change

	class DbmBound
	{
	public:
	int value; // constant coeff of the constraint
	bool strict; // is the constraint strict?
	constexpr DbmBound(int value, bool strict): value(value), strict(strict){}
	bool isInfinite() const { return value == INF; } // is this constraint unrestraining?
	bool isLooserThan(const DbmBound& other) const {
	return value > other.value || (value == other.value && strict && !other.strict);
	}
	DbmBound negate() const { assert(!isInfinite()); return DbmBound(-value, !strict); }
	};
	struct DbmBound
	{
	constexpr DbmBound(int value, bool strict): value(value), strict(strict){}
	bool isInfinite() const { return value == INF; } // is this constraint unrestraining?
	bool isLooserThan(const DbmBound& other) const {
	return value > other.value || (value == other.value && strict && !other.strict);
	}
	DbmBound negate() const { assert(!isInfinite()); return DbmBound(-value, !strict); }
	private:
	int value; // constant coeff of the constraint
	bool strict; // is the constraint strict?
	};

struct DbmBound {
   int32_t& value() { return value; }
   const int32_t& value() const { return value; }
private:
    int32_t _value:31, _strict:1;
}

[mikucionisaau]

Suggested change

	constexpr DbmBound INF_BOUND(INF,true);
	constexpr DbmBound DIAG_BOUND(0,false);
	constexpr auto INF_BOUND = DbmBound{INF,true};
	constexpr auto DIAG_BOUND = DbmBound{0,false};

[mikucionisaau]

Suggested change

	constexpr int INF = INT_MAX >> 1;
	constexpr auto INF = std::numeric_limits<int>::max() >> 1u;

[mikucionisaau]

move it to header file (either inside class or outside with inline

Suggested change

	/**
	* constructs an unrestrained matrix
	* @param dim
	* @param param
	*/
	Ppdbm::Ppdbm(int dim, int param)
	: dim(dim),
	param(param),
	DBM(dim),
	offsetCost(param + 1),
	rates(dim, std::vector<int>(param + 1))
	{}
	/**
	* constructs an unrestrained matrix
	* @param dim
	* @param param
	*/
	Ppdbm::Ppdbm(int dim, int param)
	: dim{dim},
	param{param},
	DBM{dim},
	offsetCost(param + 1),
	rates(dim, std::vector<int>(param + 1))
	{}

[mikucionisaau]

move this to DBM as a separate method

[mikucionisaau]

Suggested change

	DBM(i, j) = constraint;
	DBM(i, j) = std::move(constraint);

[mikucionisaau]

Suggested change

	DBM(i, j) = constraint;
	DBM(i, j) = std::move(constraint);

[mikucionisaau]

Suggested change

	#include "../include/dbm/ParamPricedDBM.h"
	#include "dbm/ParamPricedDBM.h"