Skip to content

[CI] Fix check_error_codes workflow #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
urfeex merged 1 commit into from
Sep 14, 2026
Merged

[CI] Fix check_error_codes workflow #568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 27 additions & 15 deletions .github/workflows/check_error_codes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
workflow_dispatch:
schedule:
- cron: '0 6 * * *' # Every night at 06:00 UTC
pull_request:
paths:
- '.github/workflows/check_error_codes.yml'
Comment on lines +7 to +9

@urfeex urfeex Sep 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub always gives GITHUB_TOKEN read-only on pull_request from forks, no matter what the workflow declares. So the write permissions don’t apply there.


jobs:
check_error_codes:
Expand Down Expand Up @@ -61,7 +64,10 @@ jobs:
echo "upstream=$UPSTREAM" >> "$GITHUB_OUTPUT"

- name: Ensure label exists
if: steps.check.outcome == 'failure' && steps.versions.outcome == 'success'
if: >-
github.event_name != 'pull_request' &&
steps.check.outcome == 'failure' &&
steps.versions.outcome == 'success'
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
Expand All @@ -71,12 +77,29 @@ jobs:
--force

- name: Regenerate header and open PR
if: steps.check.outcome == 'failure' && steps.versions.outcome == 'success'
if: >-
github.event_name != 'pull_request' &&
steps.check.outcome == 'failure' &&
steps.versions.outcome == 'success'
id: pr
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
COMMITTED: ${{ steps.versions.outputs.committed }}
UPSTREAM: ${{ steps.versions.outputs.upstream }}
PR_BODY: |
The upstream UR ErrorCodes JSON has been updated. This PR regenerates `error_code_texts.h` automatically.

| | Version |
|---|---|
| Previous header (`ERROR_CODE_JSON_VERSION`) | `${{ steps.versions.outputs.committed }}` |
| Upstream JSON | `${{ steps.versions.outputs.upstream }}` |

**Workflow run:** ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}

> [!NOTE]
> Only `include/ur_client_library/ur/error_code_texts.h` is updated here.
> If you have pending entries in `scripts/error_code_overrides.json`, verify
> they are still correct against the new JSON before merging.
run: |
BRANCH="auto/update-error-codes-v${UPSTREAM}"

Expand Down Expand Up @@ -108,22 +131,11 @@ jobs:
--label "error-codes-outdated" \
--base "${{ github.event.repository.default_branch }}" \
--head "$BRANCH" \
--body "The upstream UR ErrorCodes JSON has been updated. This PR regenerates \`error_code_texts.h\` automatically.

| | Version |
|---|---|
| Previous header (\`ERROR_CODE_JSON_VERSION\`) | \`${COMMITTED}\` |
| Upstream JSON | \`${UPSTREAM}\` |

**Workflow run:** ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}

> [!NOTE]
> Only \`include/ur_client_library/ur/error_code_texts.h\` is updated here.
> If you have pending entries in \`scripts/error_code_overrides.json\`, verify
> they are still correct against the new JSON before merging.")
--body "$PR_BODY")

echo "pr_url=$PR_URL" >> "$GITHUB_OUTPUT"
fi

- name: Fail if version mismatch
if: steps.check.outcome == 'failure'
run: exit 1
Loading