Repository navigation
StoreClientInfo/HWInfo: avoid breaking Interrogate on older servers - #1321
Merged
scudette merged 1 commit intoOct 6, 2026
Merged
Conversation
Before v0.77.1, the GUI Interrogate button searches artifacts for "Custom.Generic.Client.Info" (an unanchored regex over names and descriptions) and, on any hit, launches that artifact by name. Both descriptions contained the literal string, so importing the exchange made Interrogate fail with "Unknown artifact Custom.Generic.Client.Info" on servers without that override. Reword the descriptions only; the InterrogationArtifact defaults are unchanged.
Collaborator
|
Thanks! this is a very insidious bug :-) Great sleuthing 👍🏽 |
Contributor
Author
YAY thank you mike! 🫶 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On servers before v0.77.1, importing the Artifact Exchange breaks the GUI's Interrogate button:
In those versions,
host-info.jsxstartInterrogate()callsGetArtifactswithsearch_term: "Custom.Generic.Client.Info"and, if anything matches, launchesCustom.Generic.Client.Infoby name. The search is an unanchored regex over artifact names and descriptions (matchDescOrNameinapi/artifacts.go). The descriptions ofServer.Monitor.StoreClientInfoandServer.Monitor.StoreClientHWInfo(added in #1203) contain that literal string, so after import the search hits and the GUI launches an artifact that doesn't exist.v0.77.1+ is not affected (the GUI now launches
Generic.Client.Infowithallow_custom_overrides), but v0.76.x and older still are.Fix
Reword the two descriptions so they no longer contain the string. Parameter defaults (
InterrogationArtifact: Custom.Generic.Client.Info) and VQL are unchanged; the search never looks at them.Testing
On v0.7.1-1 (GUI mode), with the exchange imported via
Server.Import.ArtifactExchangeusing default parameters:Unknown artifact Custom.Generic.Client.Info.Generic.Client.Infoand finished.Also confirmed v0.77.3 interrogates normally with the current exchange (the bug does not apply there).