Repository navigation
feat: java 21 - #24
Merged
Merged
Conversation
Signed-off-by: MutwakilX <144057106+Wadamzmail@users.noreply.github.com>
- Guard `validateRange` in `EditorFeatures` to prevent modifying shared `Range.NONE` and `Position.NONE` sentinels. - Extract text appending logic from `EditorFeatures.append` into a new `Content.append` extension function in `contentExt.kt`. - Add an `IDEEditor.isXmlAttribute` helper function to check if a selection is an XML attribute. - Refactor `DocLint.newDocLint()` to remove cached provider streams, iterating directly over `ServiceLoader`, and add a nested `Provider` interface. - Standardize formatting, add trailing commas, and convert eligible functions to expression bodies across modified files. Signed-off-by: MutwakilX <144057106+Wadamzmail@users.noreply.github.com>
…vice` - Annotate `JrtFileSystemProvider` with `@AutoService(FileSystemProvider.class)` to automatically generate the service provider configuration file. Signed-off-by: MutwakilX <144057106+Wadamzmail@users.noreply.github.com>
- Remove usages of `AccessController.doPrivileged` and `PrivilegedAction` across multiple classes (`SystemImage`, `BasicImageReader`, `JrtFileSystemProvider`, `NativeImageBuffer`) as part of cleaning up deprecated APIs. - Simplify initialization logic in `SystemImage` for `RUNTIME_HOME` and `modulesImageExists`. - Refactor `BasicImageReader` to perform system property checks and `FileChannel` configuration directly without privileged blocks. - Update `JrtFileSystemProvider` to instantiate `JrtFsLoader` directly and refine import statements. - Simplify `NativeImageBuffer` static initializer to load the `jimage` library directly. - Replace a `String.formatted` call with `String.format` in `JavaTokenizer` for better compatibility. - Perform minor reformatting and indentation fixes across the affected files. Signed-off-by: MutwakilX <144057106+Wadamzmail@users.noreply.github.com>
the java 21 compiler parse it as annotation and crash
|
Important Review skippedToo many files! This PR contains 507 files, which is 207 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Repository: Wadamzmail/AndroidIDE/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (507)
You can disable this status message by setting the Comment |
- Add a preference to toggle IDE debug logs and update `IDELogsViewModel` to use it. - Add an experimental preference to enable Java compiler preview features (`--enable-preview`) and integrate it into `CompileBatch`. - Refactor `NBNames` to use composition with `Names` instead of extending it. - Fix a potential NPE in `JavaCompiler.newRound()` by null-checking `todo`. - Fix a potential crash in `AtcWizardDialog` by checking for null binding during back press handling. - Simplify `JrtFileSystemProvider.newFileSystem` by removing the `java.home` check and directly returning the file system. - Initialize `KotlinSnippetRepository` in `KotlinLanguageServer`. Signed-off-by: MutwakilX <144057106+Wadamzmail@users.noreply.github.com>
Signed-off-by: MutwakilX <144057106+Wadamzmail@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.