Skip to content

Improve Accessibility and Functionality #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
murshed wants to merge 7 commits into
base: trunk
Choose a base branch
from
+17 −6
Open

Improve Accessibility and Functionality #2598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
677f61a
Add security and accessibility improvements
murshed Jul 27, 2026
c417a30
Merge branch 'WordPress:trunk' into trunk
murshed Jul 27, 2026
bbf4b80
Merge branch 'trunk' into trunk
murshed Jul 27, 2026
994d7e8
Remove rel="noopener" from a tag
mukeshpanchal27 Aug 6, 2026
f717ecf
Merge branch 'trunk' into trunk
mukeshpanchal27 Aug 6, 2026
244b145
Remove rel attribute from sunset notice links
murshed Aug 13, 2026
4f5b275
Merge branch 'trunk' into trunk
mukeshpanchal27 Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions plugins/performance-lab/includes/admin/plugins.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,9 @@ function perflab_render_plugin_card( array $plugin_data ): void {

if ( $availability['activated'] ) {
$action_links[] = sprintf(
'<button type="button" class="button button-disabled" disabled="disabled">%s</button>',
'<button type="button" class="button button-disabled" disabled="disabled" aria-label="%s">%s</button>',
/* translators: %s: Plugin name. */
esc_attr( sprintf( __( '%s is active', 'performance-lab' ), $name ) ),
esc_html( _x( 'Active', 'plugin', 'default' ) )
);
} elseif (
Expand All @@ -538,15 +540,19 @@ function perflab_render_plugin_card( array $plugin_data ): void {
);

$action_links[] = sprintf(
'<a class="button perflab-install-active-plugin" href="%s" data-plugin-slug="%s">%s</a>',
'<a class="button perflab-install-active-plugin" href="%s" data-plugin-slug="%s" aria-label="%s">%s</a>',
esc_url( $url ),
esc_attr( $plugin_data['slug'] ),
/* translators: %s: Plugin name. */
esc_attr( sprintf( __( 'Activate %s', 'performance-lab' ), $name ) ),
esc_html__( 'Activate', 'default' )
);
} else {
$explanation = $availability['can_install'] ? _x( 'Cannot Activate', 'plugin', 'default' ) : _x( 'Cannot Install', 'plugin', 'default' );
$action_links[] = sprintf(
'<button type="button" class="button button-disabled" disabled="disabled">%s</button>',
'<button type="button" class="button button-disabled" disabled="disabled" aria-label="%s">%s</button>',
/* translators: 1: Plugin name, 2: Status explanation. */
esc_attr( sprintf( __( '%1$s: %2$s', 'performance-lab' ), $name, $explanation ) ),
esc_html( $explanation )
);
}
Expand Down Expand Up @@ -593,8 +599,13 @@ function perflab_render_plugin_card( array $plugin_data ): void {
if ( $availability['activated'] ) {
$settings_url = perflab_get_plugin_settings_url( $plugin_data['slug'] );
if ( null !== $settings_url ) {
/* translators: %s is the settings URL */
$action_links[] = sprintf( '<a href="%s">%s</a>', esc_url( $settings_url ), esc_html__( 'Settings', 'performance-lab' ) );
$action_links[] = sprintf(
'<a href="%s" aria-label="%s">%s</a>',
esc_url( $settings_url ),
/* translators: %s: Plugin name. */
esc_attr( sprintf( __( 'Settings for %s', 'performance-lab' ), $name ) ),
esc_html__( 'Settings', 'performance-lab' )
);
}
}
?>
Expand Down
2 changes: 1 addition & 1 deletion plugins/web-worker-offloading/helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ function plwwo_render_sunset_notice( string $plugin_file ): void {

$message = sprintf(
/* translators: 1: GitHub issue URL. 2: Support forum URL. */
__( 'The Web Worker Offloading plugin is proposed for being sunset. Please refer to the <a href="%1$s" target="_blank" rel="noopener">GitHub issue</a> for more information. If you have metrics showing how this plugin specifically improved your Interaction to Next Paint (INP), please share them in the <a href="%2$s" target="_blank" rel="noopener">support forum</a> as this could provide a reason to keep the plugin.', 'web-worker-offloading' ),
__( 'The Web Worker Offloading plugin is proposed for being sunset. Please refer to the <a href="%1$s" target="_blank">GitHub issue</a> for more information. If you have metrics showing how this plugin specifically improved your Interaction to Next Paint (INP), please share them in the <a href="%2$s" target="_blank">support forum</a> as this could provide a reason to keep the plugin.', 'web-worker-offloading' ),
esc_url( 'https://github.com/WordPress/performance/issues/2284' ),
esc_url( 'https://wordpress.org/support/plugin/web-worker-offloading/' )
);
Expand Down
Loading