Skip to content

chore: remove dead NodeEditorStrings properties - #157

Open
detail-app[bot] wants to merge 1 commit into
masterfrom
detail/dead-code/chore-remove-dead-nodeeditorstrings-properties-2ffea2
Open

detail-app[bot] wants to merge 1 commit into
masterfrom
detail/dead-code/chore-remove-dead-nodeeditorstrings-properties-2ffea2

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Removes five unused @property methods from NodeEditorStrings:
NODE_COM_FLAGS, NODE_PARAMETERS, LINK_WARNING_HIDE_COM_OBJECTS,
LINK_WARNING_REMOVED, and BTN_REMOVE_LINKS.

None have any production callers. NODE_COM_FLAGS and NODE_PARAMETERS
were orphaned when _render_node_settings was removed (commit cfebd06,
"simplify node view by removing settings section"); the three
link-warning strings were orphaned when LinkWarningDialog was deleted
(commit 38ee100, "Remove unused dialogs directory (LinkWarningDialog)").
They were carried forward already-orphaned by the i18n refactor
(15e0245) that split per-plugin strings.py files.

History

  • Last materially changed May 2026 (@kewde)

Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from kewde September 28, 2026 23:50
@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.45%. Comparing base (7f7ef57) to head (2d4aba0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   61.46%   61.45%   -0.01%     
==========================================
  Files         156      156              
  Lines       11088    11073      -15     
  Branches     1490     1490              
==========================================
- Hits         6815     6805      -10     
+ Misses       4111     4106       -5     
  Partials      162      162              
Files with missing lines Coverage Δ
...knx-gui/src/knx_gui/plugins/node_editor/strings.py 71.11% <ø> (+1.11%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant