Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fix/dynamic-activity-gates-encoding #63 +/- ##
=======================================================================
- Coverage 59.48% 59.47% -0.01%
=======================================================================
Files 137 137
Lines 10398 10397 -1
Branches 1432 1431 -1
=======================================================================
- Hits 6185 6184 -1
Misses 4081 4081
Partials 132 132
🚀 New features to boost your workflow:
|
kewde
added this pull request to stack #64
September 14, 2026 18:08
stack merge was automatically disabled
September 14, 2026 18:13
Pull Request is not mergeable
stack merge was automatically disabled
September 14, 2026 19:08
Pull Request is not mergeable
…parameter_id internally EvalContext already holds the ApplicationIndexer, and parameter_refs already maps ParameterRef id -> the Parameter/UnionParameter id it targets, so the caller (ParameterRefRefNode) no longer needs to look up and pass the target id itself. This also makes idx required on EvalContext instead of an Optional with a dead fallback branch in allocate(), since every real construction path already supplies one. Claude-Session: https://claude.ai/code/session_019yPeudwyfcjBGgTNN3Ad7p
kewde
force-pushed
the
refactor/mark-active-param-ref-id-only
branch
from
September 14, 2026 19:31
2fe3d40 to
dfad269
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #62.
EvalContext.mark_active_paramtook both aParameterRefid and theParameter/UnionParameterid it targets,with the caller (
ParameterRefRefNode) responsible for resolving thelatter itself. Since
EvalContextalready holds theApplicationIndexer, andApplicationIndexer.parameter_refsalreadymaps
ParameterRef.id -> ParameterRef.ref_id(the id it targets), theresolution belongs in
EvalContextitself rather than at every callsite.
mark_active_param(ref_id)now takes a single argument and resolvesparameter_id = self._idx.parameter_refs[ref_id].ref_idinternally.EvalContext.idxis now a required, keyword-only argument insteadof
ApplicationIndexer | Nonewith a dead-branchRuntimeErrorinallocate()- every real construction path already supplied a realindexer, so the
Nonecase only existed in tests.packages/product/tests/parser_v2/now pass
idx, via a new sharedidxpytest fixture(
tests/parser_v2/conftest.py) for tests that don't care what's inthe indexer, or a locally-built one for tests (
test_context.py,test_module.py) that already had their own.test_allocate_without_indexer_raises, which tested theidx=Nonepath that no longer exists.No behavior change:
encode_to_memory()output for thegira_2gang_button_interface.knxprodfixture is still byte-identicalbefore and after this change.
Test plan
uv run pytest packages/product(536 passed)uv run ruff check/uv run ruff format --checkuv run pyright packages/product(same 30 pre-existing errors as base branch, zero new)encode_to_memory()output byte-identical against the real fixture, before and afterapps/knx-guiimports and its test suite pass unaffected🤖 Generated with Claude Code
https://claude.ai/code/session_019yPeudwyfcjBGgTNN3Ad7p