Repository navigation
Update Playwright driver to 1.63.0 - #395
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This reverts commit 343b9d8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the compatible Playwright driver and Ruby gem to 1.63.0. Add HTTP credential arrays while preserving credentials Hashes,
dialogclosed, selectorless frame locators,Locator#visible, action ARIA/screen snapshots, and OPFS storage state. Separate context API-request tracing/HAR and recover from failed HAR/trace saves, including valid Ruby stack metadata. Update CI versions and regenerate the API, documentation, signatures, and examples.Page#frame_locatorandFrame#frame_locatorkeep the selector as an optional positional argument (selector = nil), preserving existing calls while allowing it to be omitted to search across frames. The generator handles these arguments withOptionalPositionalArgand generates matching wrappers, documentation, and RBS signatures.Closes #394.
The committed upgrade review contains the ordered review of 58 upstream PRs, additional driver-regression decisions, and the implementation/test mapping. Tests are based on the final v1.63.0 sources. Pre-existing gaps (
APIRequestContext#storage_stateand Android swipe), JS-only APIs, and reverted features remain outside this upgrade.Validation on macOS/Ruby 4.0.0, through
rbenv exec bundle exec rspec:should support contentFrametimed out inpage.gotobefore callingframe_locator. Its immediateDEBUG=1rerun passed (1 example, 0 failures), including the any-frame content-frame assertion. Both positional selectors and omitted selectors are covered.git diff --checkpassed.Firefox smoke checks could not reach test execution: r1543 reports
Could not find profile folder, also reproduced with the upstream Node client. Firefox behavior and the full CI Ruby-version matrix remain unverified locally.