Repository navigation
Conversation
jmeyers91
marked this pull request as ready for review
October 20, 2026 22:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex 0.146/0.147 is documented emitting
starting -> cancelled -> starting -> readyfor an MCP server that remains healthy (openai/codex#36682). I have not reproduced that producer behavior on the currently pinned Codex 0.160.1; this change makes the adapter handle the documented sequence safely.I recheck cancelled server names through the existing read-only, thread-scoped
mcpServerStatus/listpath with a five-second overall deadline covering requests, pagination, and polling. Sessions without cancellations make no extra status requests. A cancelled card is suppressed only when the latest complete snapshot says that server is currently connected. Status errors, incomplete pagination, timeout, and genuine cancellation preserve the failure. Session close aborts reconciliation, late responses cannot continue pagination or publish, and already-confirmed failures retain their existing publication timing.Both ACP versions have regression coverage for transient and permanent cancellations and repeated-cursor rejection. Additional controls cover thread scoping, read-only calls, a hung request and deadline, close with a late response, and multi-server latest-snapshot behavior. Removing the complete-pagination guard makes both new repeated-cursor cases fail.
Validation:
b91bf85: 1874 passed, 36 skipped.b91bf85.b91bf85.The existing foreground-state v2 integration mismatch was reproduced on the exact upstream base in the same environment during the preceding contribution. The integration suite was not rerun for this change.