Repository navigation
fix: isolate ChatGPT login attempts and handle cancellation - #696
Open
marinamdrs wants to merge 1 commit into
Open
marinamdrs wants to merge 1 commit into
marinamdrs wants to merge 1 commit into
Conversation
Match login completions by login ID instead of sharing a pending promise between attempts. Forward cancellation through ACP v1 and v2. Cancel the matching login and clean up its completion wait and elicitation. Add regression tests for cancellation, retries, and late events.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a user stops a ChatGPT login and starts another, a late completion from the first attempt can finish the second attempt. Both attempts reuse
pendingLoginCompleted, which accepts a notification without checking itsloginId. Authentication also drops the request cancellation signal.This change gives each attempt a separate completion wait, matches notifications by login ID, and forwards cancellation through ACP v1 and v2. It cancels the matching app-server login and cleans up its wait and elicitation. It also handles early notifications, cancellation before the start response, and browser-launch failures.
Validation: