Falsy Values Incorrectly Evaluated in Option Checks #354

Activity

1. agsh commented on Apr 9, 2025

   

   agsh

   on Apr 9, 2025

   Owner

   More actions

   @momoAmch hello!
   Oh... media.js.. my headache... Written a long-long time ago in ECMAScript5 and not enough tested yet. Right now I'm rewriting it in the typescript and still make this stupid mistake (

   onvif/src/media.ts

   Line 207 in cae5606

   }${configuration.useCount ? `<UseCount xmlns="http://www.onvif.org/ver10/schema">${configuration.useCount}</UseCount>` : ''

   ) 🤦
   I can offer you a temporary solution to replace a number as value to string when passing options to methods:

   function zeroes(object) {
     if (object === 0) return '0';
     if (object === null) return null;
     if (Array.isArray(object)) return object.map(zeroes);
     if (typeof object === 'object') {
       return Object.fromEntries(Object
         .entries(object)
         .map(([key, value]) => [key, zeroes(value)]));
     } 
     return object;
   }
   
   console.log(
     zeroes({
       a : null,
       b : undefined,
       c : 0,
       d : [0,1,{e : 0,f : 1}],
       g : {h : 0, i : 1, j : {k : 0}},
     }),
   );

   But this is of course not a solution. So I'm glad you want to do a PR. I'll be happy to review it 👍
   Seem that this regex covers quite a lot of this falsy cases (45 in media.js): options.[\S\)]+[\n\s]*\?
2. RogerHardiman commented on Nov 10, 2025

   

   RogerHardiman

   on Nov 10, 2025

   Collaborator

   More actions

   I'd be happy to look at a PR for the 'falsy' stuff.
   I've also got 4 Axis cameras in my collection of IP cameras (plus Bosch, Avigion, Hanwha, Sony) etc so can do some tests too.

   I'm just catching up on a year of agsh/onvif posts.