Repository navigation
ci: render the release video on a pull request before the release - #1089
Merged
Merged
Conversation
The video was only rendered once a release existed, on a runner never tried with the current renderer. A dry run on the same runner shows a broken render on the pull request and keeps the MP4 as an artifact. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019tw8HkVy69fuukqR971Roz
The dry run showed v0.0. It now renders the minor after the last release, the name the release job would give the video. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019tw8HkVy69fuukqR971Roz
The first attempt read 5.12.0 as 5.12.13. It now increments the minor and keeps the major, giving 5.13. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019tw8HkVy69fuukqR971Roz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A workflow that renders the release video on
ubuntu-latest, the runner the release job uses, with no release. The MP4 is kept as a run artifact for 7 days; nothing is attached or published.Why
The video is only rendered by
build-release-videoonce a release exists. That job came with the video plan, after the last release, so it has never run with the current renderer. A broken render would show on release day, with the release published and no video.Runs
.claude/skills/release-video/**oraidd_docs/release-video/**, so a change to the plan or the renderer is rendered before it merges.workflow_dispatch, once the file is on the default branch.Not covered
The sound is not judged here, and attaching the video to a release is still only done by the release job.
🤖 Generated with Claude Code
https://claude.ai/code/session_019tw8HkVy69fuukqR971Roz