Repository navigation
Conversation
…tTextMap getElementTextMap() only matched lines starting with [N], but flatTreeToString() emits newly-appeared (isNew) interactive elements with a *[N] prefix. Those indexes were therefore missing from elementTextMap, so PageController action feedback degraded to the bare index for isNew elements. Add regression tests covering regular, isNew, and mixed pages. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
getElementTextMap()failed to parse lines with the*[N]prefix thatflatTreeToString()emits for isNew (newly-appeared) interactive elements, so their index→text mapping was missing.Why
PageControlleruseselementTextMapto report which element an action targeted. For isNew elements the look-up returned undefined, degrading action feedback to the bare index. Since most elements are isNew on first paint, this masked element labels in common cases.How I verified
src/dom/index.test.tscovering regular, isNew, and mixed pages (they fail before the fix).npm run typecheck,npm run lint, prettier all pass.