fix: channel invitations on channels/incoming + honest reply wording - #70
Merged
Conversation
… wording The addressed-while-CLOSED [Channel invitation] block existed only in handleMcplPushEvent (discord-mcpl mentions). channels.publish surfaces (portal-mcpl) deliver mentions via handleMcplChannelIncoming, which had no invitation logic at all: an agent woken by a mention in an unjoined channel got no guidance and no route. Observed on Rhys's first portal mention (2026-07-27) — his 2,320-char reply bounced with "no destination set yet this turn". Extract buildClosedChannelInvitation() and use it on both ingest paths. Also fix the invitation's option 1: "simply write your reply as normal text" is a false promise for explicit prose-routing agents (the channelInvitation metadata it set has no consumers; nothing routes the plain reply). Teach the ">>#channel" prefix instead — which delivers for legacy AND explicit agents alike. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Portal mentions (channels.publish path) now get the same addressed-while-closed invitation as Discord mentions (push path) — shared builder. Option-1 wording now teaches the
>>#channelprefix, which actually delivers in both routing modes; the old 'reply as plain text' promise was false for explicit-prose agents (metadata flags had no consumers). Repro + full anatomy: Rhys's stranded 2,320-char portal reply, 2026-07-27. Suite green.Remaining design question (not in this PR): whether an invitation should also plant a turn-scoped destination so unprefixed replies deliver — antra's call on Option B semantics.
🤖 Generated with Claude Code